[node-patches] Change in ovirt-node[master]: only run post install hook from ovirtfunctions.py with tui i...

fabiand at fedoraproject.org fabiand at fedoraproject.org
Mon Sep 3 14:14:31 UTC 2012


Fabian Deutsch has posted comments on this change.

Change subject: only run post install hook from ovirtfunctions.py with tui install
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Implementation is fine, but why are we restricting it?

....................................................
Commit Message
Line 3: AuthorDate: 2012-08-14 22:28:54 -0400
Line 4: Commit:     Gerrit Code Review <gerrit2 at gerrit.ovirt.org>
Line 5: CommitDate: 2012-08-17 11:28:25 -0400
Line 6: 
Line 7: only run post install hook from ovirtfunctions.py with tui install
Is there a reason why we should be running the hooks only on a TUI install?
Line 8: 
Line 9: Change-Id: I359d56b284a71b7621062d92321f1d6523edce04


--
To view, visit http://gerrit.ovirt.org/7199
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359d56b284a71b7621062d92321f1d6523edce04
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>



More information about the node-patches mailing list