[node-patches] Change in ovirt-node[master]: Make sure we don't reuse Augeas objects in ovirt.node.config

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Aug 8 10:03:21 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: Make sure we don't reuse Augeas objects in ovirt.node.config
......................................................................


Patch Set 1:

In general this is the solution for the problem. But I'm a bit sceptical about the performance impact on page loading.

During writing the new backend stuff I noticed that reloading is CPU and IO bound and can take a couple of ms - and because it is done a couple of times this can to a bad user experience.

I can just imagine an independent augeas component (aka small daemon?) which offers the aug api. This way aug would become threadsafe and the data would be the same between different UI instances. But this can also be an overkill.

-- 
To view, visit http://gerrit.ovirt.org/17722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c91839c4dca91fed47d457bdb8a1f712c172822
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No



More information about the node-patches mailing list