[node-patches] Change in ovirt-node[master]: Make sure we don't reuse Augeas objects in ovirt.node.config

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Make sure we don't reuse Augeas objects in ovirt.node.config
......................................................................


Patch Set 1:

I agree in general. In this particular case I wasn't worried about the performance impact (because _get_or_set is only called for NTP and DNS servers), but if it's a persistent problem with Augeas that crops up in a page which uses it more heavily (NicDetails, or whatever) I don't mind creating a daemon. It just seems like overkill as long as the problem is limited in scope.

-- 
To view, visit http://gerrit.ovirt.org/17722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c91839c4dca91fed47d457bdb8a1f712c172822
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No