[node-patches] Change in ovirt-node[master]: Make sure we don't reuse Augeas objects in ovirt.node.config

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Make sure we don't reuse Augeas objects in ovirt.node.config
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Yes.
We can probably introduce a solution in the central augeaswrapper class, if needed.

....................................................
File src/ovirt/node/config/network.py
Line 174: def _aug_get_or_set(augpath, new_servers=None):
Line 175:     """Get or set some servers
Line 176:     """
Line 177:     aug = Augeas()
Line 178:     aug.force_reload()
We'll need to call a

    aug.save()

before the reload to prevent lossing data which was set before but was not yet saved.
Line 179: 
Line 180:     servers = []
Line 181:     for path in aug.match(augpath):
Line 182:         servers.append(aug.get(path))


-- 
To view, visit http://gerrit.ovirt.org/17722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c91839c4dca91fed47d457bdb8a1f712c172822
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes