[node-patches] Change in ovirt-node[master]: Validate passed NTP servers and reject bad ones

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Validate passed NTP servers and reject bad ones
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File scripts/ovirt-init-functions.sh.in
Line 643:             dns=*)
Line 644:             dns=${i#dns=}
Line 645:             ;;
Line 646:             ntp=*)
Line 647:             ntp=$(printf $i|python -c "`cat << EOP
I wonder if we should do this further down the line. E.g. in defaults.py, because that's the place where it should go through.
Maybe we can add the function defaults.Timeservers.configure_tolerant(list_with_valid_and_invalid_timeservers)

The function can then do what you r logic does here and write all valid timeservers.

This function can then be called in the auto-installer code.
Line 648: import sys
Line 649: from ovirt.node import valid
Line 650: validservers = []
Line 651: for line in sys.stdin:


-- 
To view, visit http://gerrit.ovirt.org/17888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb135977b4359f5fe0161215cec2cdd1b22244b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes