[node-patches] Change in ovirt-node[master]: Validate passed NTP servers and reject bad ones

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Validate passed NTP servers and reject bad ones
......................................................................


Patch Set 2:

(1 comment)

....................................................
File scripts/ovirt-init-functions.sh.in
Line 643:             dns=*)
Line 644:             dns=${i#dns=}
Line 645:             ;;
Line 646:             ntp=*)
Line 647:             ntp=$(printf $i|python -c "`cat << EOP
Agreed. I'll move it once I finish nested transactions.
Line 648: import sys
Line 649: from ovirt.node import valid
Line 650: validservers = []
Line 651: for line in sys.stdin:


-- 
To view, visit http://gerrit.ovirt.org/17888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb135977b4359f5fe0161215cec2cdd1b22244b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes