[node-patches] Change in ovirt-node[master]: RFC: synchronize log dir with iso on boot

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: RFC:  synchronize log dir with iso on boot
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File scripts/ovirt-init-functions.sh.in
Line 826: copy_dir_if_not_exist("${logsync_TMPDIR}/ext3/var/log", "/var/log")
Line 827: EOP
Line 828:         umount ${logsync_TMPDIR}/ext3
Line 829:         umount ${logsync_TMPDIR}/squash
Line 830:         rm -rf ${logsync_TMPDIR}
yes, it's ugly.  I'm open to suggestions for how to fix this better, though.  basically, the process has to be:

mount iso image
look at directories in /var/log
create those directories in HostVG-Logging /var/log directory

I considered other approaches during upgrade which I would prefer, but they don't fit well in the logic anywhere.

The code works when run manually on a running system, but not during boot.  I need to relocate the code to a different area to get it to work on boot.
Line 831: 
Line 832: 
Line 833:     fi
Line 834:     log "Updating $OVIRT_DEFAULTS"


-- 
To view, visit http://gerrit.ovirt.org/15018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2399c9cb1fb7eb9fd572f9214ee74f8a61a8ce
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>