[node-patches] Change in ovirt-node[master]: RFC: Add tuned configuration

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: RFC:  Add tuned configuration
......................................................................


Patch Set 4: (3 inline comments)

....................................................
File src/ovirt/node/config/tuned.py
Line 29:     """
Line 30:     keys = ("OVIRT_TUNED_PROFILE",)
Line 31: 
Line 32:     def update(self, profile):
Line 33:         all_profiles = tuned.get_available_profiles()
Possibly, I'll test when i update the patch
Line 34:         if profile not in all_profiles:
Line 35:             raise InvalidData("Unknown tuned profile: %s" % profile)
Line 36: 
Line 37:     def transaction(self):


Line 46:         class CallTunedAdm(utils.Transaction.Element):
Line 47:             title = "Requesting profile change"
Line 48: 
Line 49:             def commit(self):
Line 50:                 tuned.set_active_profile(profile)
No, we start tuned with the value stored in /etc/default/ovirt.  I wanted to avoid persisting the file since it's in a different location on different systems.
Line 51: 
Line 52:         tx = utils.Transaction("Applying tuned configuration")
Line 53:         if profile:
Line 54:             # Only add the element if there is a profile to be set


....................................................
File src/ovirt/node/setup/performance_page.py
Line 35:     def rank(self):
Line 36:         return 100
Line 37: 
Line 38:     def model(self):
Line 39:         profile = tuned.get_active_profile()
makes sense, I'll work on adding it.
Line 40:         model = {
Line 41:             "tuned.profile": profile,
Line 42:         }
Line 43:         return model


-- 
To view, visit http://gerrit.ovirt.org/14962
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1ed6db48bfeeed962f1bff656d71243281e1597
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>