[node-patches] Change in ovirt-node[master]: Use WatchedFileHandler instead of RotatingFileHandler

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Use WatchedFileHandler instead of RotatingFileHandler
......................................................................

Use WatchedFileHandler instead of RotatingFileHandler

Even though we just switched to RotatingFileHandler, it does not
interact well with logrotate, whereas WatchedFileHandler is
explicitly intended to deal with that use case. Additionally,
using WatchedFileHandler ensures that the logging page accurately
reflects the actual sizes of logfiles, and that our own logrotate
job performs as expected.

Change-Id: I6230b1da121a8c3711b7c09cbc8b174ee6b12032
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=976053
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M data/logging.conf
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/61/15961/1

diff --git a/data/logging.conf b/data/logging.conf
index a1e3da8..5987171 100644
--- a/data/logging.conf
+++ b/data/logging.conf
@@ -21,16 +21,16 @@
 qualname=ovirt.node
 
 [handler_file]
-class=handlers.RotatingFileHandler
+class=handlers.WatchedFileHandler
 level=INFO
 formatter=simple
-args=('/var/log/ovirt-node.log', 'w', 5000000)
+args=('/var/log/ovirt-node.log', 'w')
 
 [handler_debug]
-class=handlers.RotatingFileHandler
+class=handlers.WatchedFileHandler
 level=DEBUG
 formatter=verbose
-args=('/var/log/ovirt-node.debug.log', 'w', 5000000)
+args=('/var/log/ovirt-node.debug.log', 'w')
 
 [handler_stderr]
 class=StreamHandler


-- 
To view, visit http://gerrit.ovirt.org/15961
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6230b1da121a8c3711b7c09cbc8b174ee6b12032
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>