[node-patches] Change in ovirt-node[master]: Use WatchedFileHandler instead of RotatingFileHandler

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Use WatchedFileHandler instead of RotatingFileHandler
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

The correct solution!
Just one nitpick, we should append instead of replacing the file, this way we keep the logs of previous sessoions

....................................................
File data/logging.conf
Line 23: [handler_file]
Line 24: class=handlers.WatchedFileHandler
Line 25: level=INFO
Line 26: formatter=simple
Line 27: args=('/var/log/ovirt-node.log', 'w')
We canprobably drop the ,'w' here as 'a' is default, which matches well with logrotate
Line 28: 
Line 29: [handler_debug]
Line 30: class=handlers.WatchedFileHandler
Line 31: level=DEBUG


Line 29: [handler_debug]
Line 30: class=handlers.WatchedFileHandler
Line 31: level=DEBUG
Line 32: formatter=verbose
Line 33: args=('/var/log/ovirt-node.debug.log', 'w')
same as above
Line 34: 
Line 35: [handler_stderr]
Line 36: class=StreamHandler
Line 37: level=ERROR


-- 
To view, visit http://gerrit.ovirt.org/15961
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6230b1da121a8c3711b7c09cbc8b174ee6b12032
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>