[node-patches] Change in ovirt-node[master]: Fix OVIRT_CACHE_DIR path issue when AUTOBUILD_SOURCE_ROOT is...

wenyi at linux.vnet.ibm.com wenyi at linux.vnet.ibm.com
Thu Mar 7 01:15:56 UTC 2013


Wenyi Gao has posted comments on this change.

Change subject: Fix OVIRT_CACHE_DIR path issue when AUTOBUILD_SOURCE_ROOT is not set in autobuild
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File autobuild.sh
Line 28: fi
Line 29: 
Line 30: test -f Makefile && make -k distclean || :
Line 31: 
Line 32: OVIRT_CACHE_DIR=${AUTOBUILD_SOURCE_ROOT}/ovirt-cache
It seems the if and else case is the same code as following:

OVIRT_CACHE_DIR=${AUTOBUILD_SOURCE_ROOT-${HOME}}/ovirt-cache
Line 33: OVIRT_LOCAL_REPO=file://${AUTOBUILD_PACKAGE_ROOT}/rpm/RPMS
Line 34: export OVIRT_LOCAL_REPO OVIRT_CACHE_DIR
Line 35: 
Line 36: ./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT --with-image-minimizer


--
To view, visit http://gerrit.ovirt.org/12749
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd47b9db5ad832489a07ff8d649d0a55d903a912
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>



More information about the node-patches mailing list