[node-patches] Change in ovirt-node[master]: Fix OVIRT_CACHE_DIR path issue when AUTOBUILD_SOURCE_ROOT is...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: Fix OVIRT_CACHE_DIR path issue when AUTOBUILD_SOURCE_ROOT is not set in autobuild
......................................................................


Patch Set 2: Verified; Looks good to me, approved

(1 inline comment)

Acking this.  

Wenyi,  if you decide to switch it up to the other method in the comment in PatchSet 1, the please submit a new patch.

Thanks

....................................................
File autobuild.sh
Line 28: fi
Line 29: 
Line 30: test -f Makefile && make -k distclean || :
Line 31: 
Line 32: OVIRT_CACHE_DIR=${AUTOBUILD_SOURCE_ROOT-${HOME}}/ovirt-cache
Just a warning, as a result of this, if you're using Autobuild, ovirt-cache will now be *in* AUTOBUILD_SOURCE_ROOT instead of at the same level.  It's not a functional problem, and shouldn't cause any issues, but wanted to highlight it, just in case that's not something you want.
Line 33: OVIRT_LOCAL_REPO=file://${AUTOBUILD_PACKAGE_ROOT}/rpm/RPMS
Line 34: export OVIRT_LOCAL_REPO OVIRT_CACHE_DIR
Line 35: 
Line 36: ./autogen.sh --prefix=$AUTOBUILD_INSTALL_ROOT --with-image-minimizer


--
To view, visit http://gerrit.ovirt.org/12749
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd47b9db5ad832489a07ff8d649d0a55d903a912
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>