[node-patches] Change in ovirt-node[master]: Fix SELinux context for /dev/HostVG/Logging

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Fix SELinux context for /dev/HostVG/Logging
......................................................................


Patch Set 2: Do not submit

(1 inline comment)

....................................................
File src/ovirt/node/installer/progress_page.py
Line 270:             self.title = self.title_tpl % kbd_layout
Line 271:             super(InstallerThread.SetKeyboardLayout, self).__init__()
Line 272: 
Line 273:         def commit(self):
Line 274:             from ovirt.node.utils import process
This is actually a class for handling the keyboard.
Beside that criticism, that relabeing should happen somewhere else . e.g. during bootup or in ovirtnode/install.py or so ...
Here it would only have affect in UI installations.
Line 275:             utils.system.Keyboard().set_layout(self.kbd_layout)
Line 276:             log_partition = process.check_output("grep Logging /proc/mounts | grep writable")
Line 277:             process.call("chcon -R system_u:object_r:var_log_t:s0 %s" % log_partition)


--
To view, visit http://gerrit.ovirt.org/14662
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d8834a446e39c83331515e288ad932bb9de9ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>