[node-patches] Change in ovirt-node[master]: Fix SELinux context for /dev/HostVG/Logging

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Fix SELinux context for /dev/HostVG/Logging
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirtnode/ovirtfunctions.py
Line 1081:     logging_mount_cmd = "grep %s /proc/mounts | grep writable | awk '{print $2}'" % logging_dev
Line 1082:     logging_mount = subprocess_closefds(logging_mount_cmd, shell=True, stdout=PIPE, stderr=STDOUT)
Line 1083:     (logging_mount_output, dummy) = logging_mount.communicate()
Line 1084:     system("chcon -R system_u:object_r:var_log_t:s0 %s" % logging_mount_output)
Line 1085:     system("chcon -R system_u:object_r:auditd_log_t:s0 %s/audit/" % logging_mount_output)
can't we hardcode the paths here?
Normally I'm also against hardcoding, but /var/log is pretty static ..

Or do you want to achieve something else?
Line 1086: 
Line 1087:     # run post-install hooks
Line 1088:     # e.g. to avoid reboot loops using Cobbler PXE only once
Line 1089:     # Cobbler XMLRPC post-install trigger (XXX is there cobbler SRV record?):


--
To view, visit http://gerrit.ovirt.org/14662
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d8834a446e39c83331515e288ad932bb9de9ec
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>