[node-patches] Change in ovirt-node[master]: Start rsyslog after ovirt-post to fix logging visibility

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Start rsyslog after ovirt-post to fix logging visibility
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File scripts/ovirt-init-functions.sh
Line 814:             service auditd restart
Line 815:         else
Line 816:             mount -a
Line 817:             swapon -a
Line 818:         fi
While I know I moved this to a different function without changing the code much, I feel that the flow of what's happening (and why we're trying to remount all filesystem) is better when it's immediately after mount_config.  It only needs to happen after _start_ovirt_early, though, and it won't happen with "firstboot" specified here, so moving it back is certainly an option.
Line 819: 
Line 820:     fi
Line 821:     log "Updating $OVIRT_DEFAULTS"
Line 822:     tmpaug=$(mktemp)


--
To view, visit http://gerrit.ovirt.org/14663
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4887d4066db169d592cce3eee4b3587a28aab37
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>