[node-patches] Change in ovirt-node[master]: Start rsyslog after ovirt-post to fix logging visibility

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Start rsyslog after ovirt-post to fix logging visibility
......................................................................


Patch Set 3: Verified; No score

(2 inline comments)

....................................................
Commit Message
Line 5: CommitDate: 2013-05-13 17:21:45 -0700
Line 6: 
Line 7: Start rsyslog after ovirt-post to fix logging visibility
Line 8: 
Line 9: Temporary fix for service race condition
Just something minor, please add a space before the rhbz# line. It'd also be good if you give a short description of what and how this patch fixes
Line 10: rhbz#953963
Line 11: 
Line 12: Change-Id: Id4887d4066db169d592cce3eee4b3587a28aab37


....................................................
File scripts/ovirt-init-functions.sh
Line 814:             service auditd restart
Line 815:         else
Line 816:             mount -a
Line 817:             swapon -a
Line 818:         fi
Yes, I think this solution is nice. And the previous place (before mount_config was called) was definetly the wrnog place, doing the systemd reload here makes more sense.
Line 819: 
Line 820:     fi
Line 821:     log "Updating $OVIRT_DEFAULTS"
Line 822:     tmpaug=$(mktemp)


--
To view, visit http://gerrit.ovirt.org/14663
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4887d4066db169d592cce3eee4b3587a28aab37
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>