[node-patches] Change in ovirt-node[master]: Fix SELinux context for /dev/HostVG/Logging

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Fix SELinux context for /dev/HostVG/Logging
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirtnode/ovirtfunctions.py
Line 1077:         system("umount /boot")
Line 1078: 
Line 1079:     # fix SELinux
Line 1080:     logging_dev = findfs("LOGGING")
Line 1081:     logging_mount_cmd = "grep %s /proc/mounts | grep writable |
a string can't go over two lines  - only when using """…""" but you can use

  x = ("foo" + 
       "bar %s") % "x"

here
Line 1082:                          awk '{print $2}'" % logging_dev
Line 1083:     logging_mount = subprocess_closefds(logging_mount_cmd, shell=True,
Line 1084:                                         stdout=PIPE, stderr=STDOUT)
Line 1085:     (logging_mount_output, dummy) = logging_mount.communicate()


--
To view, visit http://gerrit.ovirt.org/14662
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d8834a446e39c83331515e288ad932bb9de9ec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>