[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

Eli Qiao taget at linux.vnet.ibm.com
Thu May 16 07:40:32 UTC 2013


Eli Qiao has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 3: I would prefer that you didn't submit this

hi Joey

it it good to call ovirt_store_config_atomic in ovirt_store_config, but the function ovirt_store_config_atomic only return true/false

What we want is to return more status other than true/false.

I suggest we add more return code in ovirt_store_config_atomic.

Thanks Eli.

--
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>



More information about the node-patches mailing list