[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

[baichm at linux.vnet.ibm.com]

Changming Bai has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 3:

Hi, Jboggs
I add the return rc=3/4/5/6 value in the script, in order to judge which kind of error occurred when the persist command complement.
For example:
Case 1
1. in the rhevh system, persist "test" file succcessful and check the return value is 0 (echo $?)
2. after step 1, persist the "test" file again, there will shown error messge "File already persisted: test", check the return value also is 0

Case 2
1. in the read only partition, persist "test" file, there will shown error message "Cannot persist: test"
2. after step 1, check the return value also is 0

So, I think we need to discriminate different error value from the different failure persist case.
But in your patch, there also can not return different error value form the persist failure.

--
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>