[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 3:

The problem with adding these error codes in the python is that a number of places depend on True/False return including code that does not live in ovirt-node.  We can't really change the interface of the python function and I'd much prefer not having the persist code in multiple locations.

How about this:

* move the ovirt_store_config code into a new function (name doesn't really matter).  
* have it return a different rc based on failure reason, similar to the changes proposed in the bash version
* have the bash function wrap the new function
* change the python ovirt_store_config to wrap the new function, but translate the rc from 0,1,2,3... to True/False

Make sense?

--
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>