[node-patches] Change in ovirt-node[master]: Remove, don't disable, bond creation button when managed

rbarry at redhat.com rbarry at redhat.com
Tue Apr 1 19:04:45 UTC 2014


Ryan Barry has uploaded a new change for review.

Change subject: Remove, don't disable, bond creation button when managed
......................................................................

Remove, don't disable, bond creation button when managed

Instead of just disabling the button so it can't be used, don't
even show it. Unfortunately, UIElements don't *quite* behave like
normal datastructures, so we can't just delete it, and we don't
add it in the first place

Change-Id: I827df18f53576e397dd93b95af2e54f5f9b5b06e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1083138
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/network_page.py
1 file changed, 11 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/39/26339/1

diff --git a/src/ovirt/node/setup/core/network_page.py b/src/ovirt/node/setup/core/network_page.py
index 152e38c..5d2416f 100644
--- a/src/ovirt/node/setup/core/network_page.py
+++ b/src/ovirt/node/setup/core/network_page.py
@@ -185,13 +185,19 @@
               ui.Entry("ntp[1]", _("NTP Server 2:")),
               ui.Divider("divider[2]"),
               NicTable("nics", height=3),
-
-              ui.Row("row[0]",
-                     [ui.Button("button.ping", _("Ping")),
-                      ui.Button("button.toggle_bond", bond_lbl)
-                      ])
               ]
 
+        if not has_managed_ifnames():
+            ws.extend([ui.Row("row[0]",
+                              [ui.Button("button.ping", _("Ping")),
+                               ui.Button("button.toggle_bond", bond_lbl)
+                               ])
+                       ])
+
+        else:
+            ws.extend([ui.Row("row[0]",
+                              [ui.Button("button.ping", _("Ping"))])])
+
         page = ui.Page("page", ws)
         # Save it "locally" as a dict, for better accessability
         self.widgets.add(page)


-- 
To view, visit http://gerrit.ovirt.org/26339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I827df18f53576e397dd93b95af2e54f5f9b5b06e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list