[node-patches] Change in ovirt-node[master]: Remove, don't disable, bond creation button when managed

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Remove, don't disable, bond creation button when managed
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26339/1/src/ovirt/node/setup/core/network_page.py
File src/ovirt/node/setup/core/network_page.py:

Line 186:               ui.Divider("divider[2]"),
Line 187:               NicTable("nics", height=3),
Line 188:               ]
Line 189: 
Line 190:         if not has_managed_ifnames():
To remove redundancies, could we use:

    btn_row = ui.Row("row[0]", [ui.Button("ping", ...)])
    if not managed:
        row.children.append(ui.Button("bond", ...))
    ws.append(btn_row)

Or something like that. The doubled ping-button grabbed my attention ..
Line 191:             ws.extend([ui.Row("row[0]",
Line 192:                               [ui.Button("button.ping", _("Ping")),
Line 193:                                ui.Button("button.toggle_bond", bond_lbl)
Line 194:                                ])


-- 
To view, visit http://gerrit.ovirt.org/26339
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I827df18f53576e397dd93b95af2e54f5f9b5b06e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes