[node-patches] Change in ovirt-node[master]: edit-node: handle the "file://" type of baseurl for yum repo

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: edit-node: handle the "file://" type of baseurl for yum repo
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/21244/4/tools/edit-node
File tools/edit-node:

Line 960:                 except:
Line 961:                     item = ""
Line 962:                 if os.path.exists(item):
Line 963:                     os.system("mkdir %s/%s" % (self._instroot, item))
Line 964:                     cmd = "mount -o bind %s %s/%s" \
Where does the unmount happen?
Line 965:                         % (item, self._instroot, item)
Line 966:                     f = subprocess.Popen(cmd, shell=True, stdout=PIPE,
Line 967:                                          stderr=STDOUT)
Line 968:                     output, err = f.communicate()


Line 969:                     if f.returncode > 0:
Line 970:                         self._print_err(cmd)
Line 971:                         self._print_err(output)
Line 972:                         self._print_err("Can't Bind Mount rpm directory")
Line 973:                         return False
What happens if item = ""?
Line 974:                 return True
Line 975:             elif os.path.isdir(options.repo) or \
Line 976:                     options.repo.lower().endswith(".iso"):
Line 977:                 if options.repo.lower().endswith(".iso"):


-- 
To view, visit http://gerrit.ovirt.org/21244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44264f0c62c8785c0b4867fda1e45522d32fc1f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes