[node-patches] Change in ovirt-node[master]: Build oVirt Node on F20

fabiand at fedoraproject.org fabiand at fedoraproject.org
Fri Feb 28 12:02:18 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: Build oVirt Node on F20
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/22433/2/ovirt-node.spec.in
File ovirt-node.spec.in:

Line 66: Requires:       PyPAM
Line 67: Requires:       ethtool
Line 68: Requires:       cracklib-python
Line 69: Requires:       dracut
Line 70: %if %{is_f20}
hostname is provided by the hostname pkg on el7, f19+

Only on el6 hostname is provided by net-tools.

I'd suggest that we can the codition to:

    %if is_el6_foo
    Requires: /bin/hostname
    %else
    Require: hostname
    %endif
Line 71: Requires:       /usr/bin/hostname
Line 72: %else
Line 73: Requires:       /bin/hostname
Line 74: %fi


-- 
To view, visit http://gerrit.ovirt.org/22433
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a60d4c42fa30c4a7bd009b2e4437d8213b6305e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list