[node-patches] Change in ovirt-node[ovirt-3.5]: Config.exists: fix exists method

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Config.exists: fix exists method
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/44727/2/src/ovirt/node/utils/fs/__init__.py
File src/ovirt/node/utils/fs/__init__.py:

Line 676:         if filename and self.is_enabled():
Line 677:             from ovirtnode import ovirtfunctions
Line 678:             return ovirtfunctions.ovirt_safe_delete_config(filename)
Line 679: 
Line 680:     def exists(self, filename):
> This change can not be made, because we change the semantics of exists() - 
I believe we improving not changing semantics. There were cases where files changed in FS and applications called persist and it doesn't copy the new version to /config as the validation was only if the file exists. What we could improve IMO, is change the 'return true' for 'return filename' to mimic the previous functions (even in master, this patch is a backport). Please let me know your thoughts.
Line 681:         """Check if the given file is persisted
Line 682:         """
Line 683:         persisted_path = self._config_path(filename)
Line 684: 


-- 
To view, visit https://gerrit.ovirt.org/44727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba23d67516f1690b223e3dd43985e5d9a502ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes