[node-patches] Change in ovirt-node[ovirt-3.5]: Config.exists: fix exists method

dougsland at redhat.com dougsland at redhat.com
Wed Aug 12 17:37:05 UTC 2015


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Config.exists: fix exists method
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/44727/2//COMMIT_MSG
Commit Message:

Line 9: The exists method is used by the persist script
Line 10: to check if the file that will be persisted
Line 11: exists. However, in commit 9a1986a8 we moved
Line 12: from ovirtfunctions.ovirt_store approach and missed
Line 13: to update the exists method.
> I don't see the exists() method in ovirtfunctions.
I meant, the previous implementation also was using with the fs.exists(). 
I have replied the second question, in the other comment.
Line 14: 
Line 15: Change-Id: If1ba23d67516f1690b223e3dd43985e5d9a502ef
Line 16: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1251867


-- 
To view, visit https://gerrit.ovirt.org/44727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba23d67516f1690b223e3dd43985e5d9a502ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes



More information about the node-patches mailing list