[Users] make rpm error

[Steve Gordon]

----- Original Message -----
> From: "Eyal Edri" <eedri at redhat.com>
> To: "Steve Gordon" <sgordon at redhat.com>
> Cc: "??????" <zorro at megatrone.ru>, arch at ovirt.org, users at ovirt.org, "Laszlo Hornyak" <lhornyak at redhat.com>, "Ofer
> Schreiber" <oschreib at redhat.com>, "infra" <infra at ovirt.org>
> Sent: Monday, April 9, 2012 9:56:08 AM
> Subject: Re: [Users] make rpm error
> 
> 
> 
> ----- Original Message -----
> > From: "Steve Gordon" <sgordon at redhat.com>
> > To: "Laszlo Hornyak" <lhornyak at redhat.com>
> > Cc: "??????" <zorro at megatrone.ru>, arch at ovirt.org, users at ovirt.org
> > Sent: Monday, April 9, 2012 4:21:55 PM
> > Subject: Re: [Users] make rpm error
> > 
> > ----- Original Message -----
> > > From: "Laszlo Hornyak" <lhornyak at redhat.com>
> > > To: "??????" <zorro at megatrone.ru>
> > > Cc: users at ovirt.org, "Steve Gordon" <sgordon at redhat.com>
> > > Sent: Friday, April 6, 2012 9:12:06 AM
> > > Subject: Re: [Users] make rpm error
> > > 
> > > Hi,
> > > 
> > > Jenkins is complaining about the same thing, I believe this is
> > > where
> > > it went wrong:
> > > http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/191/
> > > 
> > > Related change:
> > > http://gerrit.ovirt.org/#patch,sidebyside,3337,2,packaging/fedora/spec/ovirt-engine.spec.in
> > > 
> > > Just guessing but maven is not installed on the OS, is that the
> > > problem?
> > > 
> > > Laszlo
> > 
> > Maven must be installed, otherwise builds would never work on it,
> > but
> > I am guessing it has been installed manually outside of the package
> > manager otherwise this dependency would be met.
> > 
> > CC'ing arch at ovirt.org:
> > 
> > How is maven installed on the jenkins host? Can we get it installed
> > from RPMs?
> > 
> 
> Jenkins doesn't install the maven package, but uses a mvn bin under
> $JENKINS_HOME/tools/$mvn_ver/bin/mvn.
> 
> I'm not sure that requiring the 'maven' rpm in the make is wise, than
> rather checking if 'mvn' can be run instead,
> since this a standalone pkg that can be on os even without an rpm
> installed.

If that was actually a valid reason to not specify package requirements we would never specify any BuildRequires or Requires declarations in the spec file because the packages 'might' have been manually installed. Without this declaration the SRPM we are providing in the builds on ovirt.org can not be used to build in a clean environment such as that provided by mock. Note that this declaration was already in the version submitted to Fedora for review [1] because otherwise it would never pass...

> but for now, i can make sure all jenkins slaves have the 'maven' rpm
> installed to solve this issue.

Thanks.

Steve

[1] http://jhernand.fedorapeople.org/rpms/ovirt-engine/3.0.0_0001-6/ovirt-engine.spec