[Users] forced shutdown with client agent

[Michal Skrivanek]

On Apr 22, 2013, at 12:56 , Simon Grinberg <sgrinber at redhat.com> wrote:

> 
> 
> ----- Original Message -----
>> From: "Michal Skrivanek" <michal.skrivanek at redhat.com>
>> To: users at ovirt.org, "Thomas Scofield" <tscofield at gmail.com>, "Vinzenz Feenstra" <vfeenstr at redhat.com>, "Barak
>> Azulay" <bazulay at redhat.com>, "Gal Hammer" <ghammer at redhat.com>
>> Sent: Monday, April 22, 2013 11:48:18 AM
>> Subject: Re: [Users] forced shutdown with client agent
>> 
>> 
>> On Apr 20, 2013, at 22:42 , Itamar Heim <iheim at redhat.com> wrote:
>> 
>>> On 03/29/2013 04:58 AM, Thomas Scofield wrote:
>>>> I have run into a scenario after installing the client agent.  If
>>>> a VM
>>>> is shutdown, the client agent calls the shutdown command with a 1
>>>> minute
>>>> timeout.
>>>> 
>>>> Dummy-2::INFO::2013-03-28
>>>> 14:05:21,892::vdsAgentLogic::138::root::Shutting down (timeout =
>>>> 30,
>>>> message = 'System Administrator has initiated shutdown of this
>>>> Virtual
>>>> Machine. Virtual Machine is shutting down.'
>>>> 
>>>> Since the shutdown command is called with time parameter the VM
>>>> sets the
>>>> /etc/nologin file. When the VM is forced down the /etc/nologin
>>>> file is
>>>> not cleared and when it comes back up only root can login until
>>>> the
>>>> /etc/nologin file is cleared.
>>> 
>>> hmmm, Vinzenz - should guest agent clear that on guest startup, if
>>> guest agent set this at shutdown?
>>> 
>>>> 
>>>> Is their some some reason the shutdown time is set to 30 seconds
>>>> (rounded up to 1 minute in the code)?  Are there any know issues
>>>> with
>>>> setting this to 0?
>> I wouldn't mind changing this to 0 by default if there are no
>> objections.
>> Barak, Gal, what do you think? Do you see any strong reason for
>> keeping a grace period?
> 
> The idea was to allow a logged in user to orderly close his work right?
> For that I'm not sure that even 30 seconds is enough. 
For that typically sysadmins use 5 or 10 minutes. 30s is worthless, no one would be able to react that fast…so to me this is the same as initiating shutdown right away. It's graceful anyway and all common apps would save the workspace on SIGTERM anyway. Well, does it even do anything on Windows?
That's why I'd vote for 0. And keep is configurable in case you want to use it, sure.

> 
> So this shutdown grace period really depend if there are users connected to the VM or not. 
> The question is how to easily distinguish - maybe depend on a spice session connection? That may be too heuristic.
> 
> But in any case the timeout should be per configuration and not be up-to-doubled in the code. 
yes, that's wrong

> 
> 
>> 
>>> 
>>> Vinzenz - if we are rounding up - is this a bug?
>>> 
>>>> 
>>>> Is this the right way to change it to 0?
>>>> psql engine postgres -c "update vdc_options set option_value = '0'
>>>> where
>>>> option_name = 'VmGracefulShutdownTimeout';"
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Users mailing list
>>>> Users at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/users
>>>> 
>>> 
>> 
>> _______________________________________________
>> Users mailing list
>> Users at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/users
>>