[Users] Excessive syslog logging from vdsm/sampling.py

[Nir Soffer]

----- Original Message -----
> From: "Sander Grendelman" <sander at grendelman.com>
> To: "Itamar Heim" <iheim at redhat.com>
> Cc: users at ovirt.org, "Michal Skrivanek" <mskrivan at redhat.com>
> Sent: Wednesday, December 18, 2013 11:40:36 AM
> Subject: Re: [Users] Excessive syslog logging from vdsm/sampling.py
> 
> - vdsm-4.13.0-11.el6.x86_64
> - FC storage domain
> - no floppies attached to VMs as far as I know (any way to test this?)
> 
> On Wed, Dec 18, 2013 at 10:21 AM, Itamar Heim <iheim at redhat.com> wrote:
> > On 12/17/2013 09:04 AM, Sander Grendelman wrote:
> >>
> >> Any ideas on this one?
> >>
> >> On Mon, Dec 16, 2013 at 11:31 AM, Sander Grendelman
> >> <sander at grendelman.com> wrote:
> >>>
> >>> The syslog on my ovirt nodes is constantly logging errors from
> >>> sampling.py:
> >>>
> >>> Dec 16 11:22:47 gnkvm01 vdsm vm.Vm ERROR
> >>> vmId=`66aa5555-2299-4d93-931d-b7a2e421b7e9`::Stats function failed:
> >>> <AdvancedStatsFunction _highWrite at 0x1733dc0>#012Traceback (most
> >>> recent call last):#012  File "/usr/share/vdsm/sampling.py", line 351,
> >>> in collect#012    statsFunction()#012  File
> >>> "/usr/share/vdsm/sampling.py", line 226, in __call__#012    retValue =
> >>> self._function(*args, **kwargs)#012  File "/usr/share/vdsm/vm.py",
> >>> line 509, in _highWrite#012    if not vmDrive.blockDev or
> >>> vmDrive.format != 'cow':#012AttributeError: 'Drive' object has no
> >>> attribute 'format'

This is not spam, but a real error in the code:

    Dec 16 11:22:47 gnkvm01 vdsm vm.Vm ERROR vmId=`66aa5555-2299-4d93-931d-b7a2e421b7e9`::Stats function failed:
        <AdvancedStatsFunction _highWrite at 0x1733dc0>#012Traceback (most recent call last):
        File "/usr/share/vdsm/sampling.py", line 351, in collectstatsFunction()
        File "/usr/share/vdsm/sampling.py", line 226, in __call__
            retValue = self._function(*args, **kwargs)
        File "/usr/share/vdsm/vm.py", line 509, in _highWrite
            if not vmDrive.blockDev or vmDrive.format != 'cow':
        AttributeError: 'Drive' object has no attribute 'format'

We should check why vmDrive does not have the format attribute in your case. The best way to resolve this would be to
open a bug and attach vdsm logs, which may explain why this is happening.

Thanks for reporting it!

Thanks,
Nir