[Users] [GSOC][Gerrit] add potential reviewers - questions

Wed Mar 12 03:17:08 UTC 2014

On 03/11/2014 11:17 PM, Tomasz Kołek wrote:
> Hi,
> Thank You for the answers, these  give me basic look at the problem.
> 
> Is not a problem (from my point of view) to implement a few flags for the command, like:
> add reviewers  --auto  --max=5 --using_blame etc, depends only on our requirements.
> 
> I'm almost sure that good way is automatic way as Eyal mentioned, I know it might make a little mess but will be easier for new contributor.
> Why almost? Because what with a situation where all of potential reviewers are not interested to review patch?
> 
> Maybe we should try to find "the most reviewing" people, maybe it will be good way?
That is another method of adding reviewers,
see my suggestion in the thread which I addressed the way we should
implement the algorithms for adding reviewers, so that it will be more
generic.
> 
> 
> BR, 
> Tomek
> 
> -----Original Message-----
> From: Maor Lipchuk [mailto:mlipchuk at redhat.com] 
> Sent: Tuesday, March 11, 2014 8:40 PM
> To: Meital Bourvine; Eyal Edri
> Cc: Tomasz Kołek; users at ovirt.org; infra
> Subject: Re: [Users] [GSOC][Gerrit] add potential reviewers - questions
> 
> Hi Tomasz,
> 
> I'm very please to hear that you are interested in the GSOC project, see my answers inline.
> 
> It's great to see that you know the material pretty well, I'm interested to hear some more ideas and feedbacks.
> I will start a thread soon (Maybe also schedule a call) once getting more feedbacks from other contributors, so we can brain storm some more and get practical with it.
> If you have any more questions, please don't hesitate to ask me.
> 
> thanks,
> Maor
> 
> On 03/11/2014 04:53 PM, Meital Bourvine wrote:
>> Eyal,
>>
>> I think that he's asking about [1].
>>
>> As far as I understand, the idea is to automatically get the reviewers names, with commands like `git blame`, or from gerrit - get previous reviewers to the same file/module...
>>
>> Adding Maor, since he might have some additional info.
>>
>> [1] 
>> http://www.ovirt.org/Summer_of_Code#Idea:_Gerrit_add_potential_reviewe
>> rs
>>
>> ----- Original Message -----
>>> From: "Eyal Edri" <eedri at redhat.com>
>>> To: "Tomasz Kołek" <tomasz-kolek at o2.pl>
>>> Cc: users at ovirt.org, "infra" <infra at ovirt.org>
>>> Sent: Tuesday, March 11, 2014 4:37:22 PM
>>> Subject: Re: [Users] [GSOC][Gerrit] add potential reviewers - 
>>> questions
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Tomasz Kołek" <tomasz-kolek at o2.pl>
>>>> To: users at ovirt.org
>>>> Sent: Monday, March 10, 2014 9:56:28 PM
>>>> Subject: [Users] [GSOC][Gerrit] add potential reviewers - questions
>>>>
>>>>
>>>>
>>>> Hi
>>>>
>>>> I'd like to contribute (within GSOC) in idea: Gerrit add potential 
>>>> reviewers.
>>>>
>>>> Maybe at first I’ll introduce myself.
>>>> I'm Tomek, student from Poland. I study Computer Science at 
>>>> University of Wroclaw. The next year will be last year of my first degree study, I hope.
>>>> As a python programmer I'm working since one year at Nokia Solutions 
>>>> and Networks (don't worry I intend to change my job to another or to 
>>>> participation at GSOC). Every day at work and school I'm using 
>>>> version control system (Git and SVN). At work we were using to 
>>>> Gerrit as a review system but currently we're using JIRA to report review statuses.
>>>> I love spend my free time in mountains (mainly polish - Tatras mountains).
>>>> That's all about me.
>>>>
>>>> I've got a few questions about project description.
>>>> Please tell me if my problem's understanding is good or not.
>>>> We need to add a few flags/methods to git review module. This flags 
>>>> should allow to add potential reviewers in gerrit.
>>>> So:
>>>> Let's assume that we've got special flags for this operations. What's next?
>>>> 1. In gerrit system we need to add special place for potential reviewers?
> Adding a plugin to gerrit is an interesting idea although it will require the administrator to add it in the server, and I want that the operation will be more available to any submitter in any project.
> I think that we can address it in a later phase though.
>>>> 2. Potential reviewers should agree that they want to review?
> no, since gerrit does not question the reviewer if he wants to be added or not I think we should keep this behaviour as well.
> 
> although as I see it, the operation of adding the reviewers, will not be completely automatic for the submitter, we should let the submitter of the patch to choose which reviewers he wants to add, very similar to the screen being used when doing a rebase in git. (see attached file
> add_reviewers.png)
>>>> 3. We can have more than one accepted reviewer?
> Yes, that is correct.
>>>
>>> Hi Tomasz,
>>> I'm not sure i understood exactly what you mean by 'potential reviewers'.
>>> do want gerrit (hook?) to automatically add reviewers to a patch 
>>> according to the code sent?
>>> so in fact you'll have a place somewhere for mapping code & specific 
>>> developers?
>>>
>>> cause if you mean by adding reviewers to a patch, that's easily done 
>>> by just clicking the '+' sign on each patch.
>>> those reviewers should have logged in at least once to 
>>> gerrit.ovirt.org in order to be in the list of potential viewers, and 
>>> they don't require any special permissions to review with +1/-1 any 
>>> patch sent.
>>> you can add as many reviewers as you want to a patch.
>>>
>>> does that answer your question?
>>>
>>> Eyal.
>>>
>>>
>>>
>>>>
>>>> I know above questions might seem chaotic but I think answers allow 
>>>> me to better understanding Yours needments
>>>>
>>>> Best regards
>>>> Tomasz Kolek
>>>>
>>>> _______________________________________________
>>>> Users mailing list
>>>> Users at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/users
>>>>
>>> _______________________________________________
>>> Users mailing list
>>> Users at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/users
>>>
> 
>