[ovirt-users] Proposing fix for EL6 m2crypto memory leak

[Daniel Helgenberger]

On 28.10.2014 14:02, Dan Kenigsberg wrote:
> On Tue, Oct 28, 2014 at 11:55:40AM +0100, Sandro Bonazzola wrote:
>> Il 28/10/2014 11:07, Daniel Helgenberger ha scritto:
>>> Hello Sandro,
>>>
>>> I just updated BZ [1] that m2crypto-0.21.1 from FC20 fixes the severe
>>> mem leak issue in VDSM for me on EL6 with Engine 3.4 and 3.5.
>>>
>>> As I have seen no side effects, I propose adding a newer m2crypto to the
>>> ovirt EL6 repos; with fixes the issue immediately (well, you need to
>>> restart vdsmd).
>>>
>>> Should I open an RFE or will this mail to the list suffice? For
>>> convenience, I added the rpm I am using as well as the SRPM I used to
>>> compile this version [2].
>>
>> Let me see if I've understood.
>> Fedora 20 already have m2crypto-0.21.1-13.fc20
>> Fedora 19 has m2crypto-0.21.1-11
>>
>> Looking at the RPM changelog [1], 0.21.1-11 on F19 and your 0.21.1-12 on F20 are just mass rebuild so no update needed on Fedora.
>>
>> CentOS 7 has m2crypto-0.21.1-15 and don't need an update.
>>
>> CentOS 6.6 has m2crypto-0.20.2-9 (yes, centos 6.6 is out http://isoredirect.centos.org/centos/6.6/)
>> which looks the same on 6.5.
>> Are you really sure that the issue is on m2crypto side and not on vdsm side?
>> If so, a bug against m2crytpo should be opened and quickly fixed on RHEL/CentOS.
>>
>> I don't think that just rebuilding m2crypto from F20 is a long term solution.
>>
>> Dan?
>
> If indeed Bug 1147148 - M2Crypto usage in vdsm leaks memory
> does not manifest itself with m2crypto-0.21.1 and is limited to el6,
> it's great news.
That's an educated guess by me. At least I know for a fact:
- Leak on EL6 running EL6 m2crypto
- No leak on FC20 running FC20 m2crypto
- No leak on EL6 running FC20 m2crypto
Further I guess this issue is also gone with EL7 (I will test this soon 
as I migrate my hosts to EL7).

>
> I've move the bug to RHEL6's m2crypto. I hope it can be solved there,
> properly.
Thanks for taking care of that. Can you please post the BZ here for me 
to keep track?

>
> Until this takes place, we can place Daniel's m2crypto build somewhere
> and suggest people to use it (preferably, we'd take a koji scratch build).
>
> We should not drop it into the default ovirt repo just yet, as no
> package is error free, so we should better check this new m2crypto
> first.
True. A hint in Release Nots / known issues should do the trick in the 
mean time.
>
>>
>> [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=485699
>>
>>
>>
>>>
>>>
>>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1147148
>>> [2]
>>> ftp://rpmfind.net/linux/fedora-secondary/development/rawhide/source/SRPMS/m/m2crypto-0.21.1-12.fc20.src.rpm
>>>
>>
>>
>> --
>> Sandro Bonazzola
>> Better technology. Faster innovation. Powered by community collaboration.
>> See how it works at redhat.com
>

-- 
Daniel Helgenberger
m box bewegtbild GmbH

P: +49/30/2408781-22
F: +49/30/2408781-10

ACKERSTR. 19
D-10115 BERLIN


www.m-box.de  www.monkeymen.tv

Geschäftsführer: Martin Retschitzegger / Michaela Göllner
Handeslregister: Amtsgericht Charlottenburg / HRB 112767