[ovirt-users] engine-iso-uploader unexpected behaviour (steve a)

[Steve Atkinson]

Excellent. Confirmed, this fixes the bug and fails with a more descriptive
error.

Steve Atkinson
Director, Network Ops
Telvue Corporation
satkinson at telvue.com
O: 800 885 8886 x240
C: 856 938 9125

On Thu, Jan 1, 2015 at 3:52 AM, Yedidyah Bar David <didi at redhat.com> wrote:

> ----- Original Message -----
> > From: "Yedidyah Bar David" <didi at redhat.com>
> > To: "Steve Atkinson" <satkinson at telvue.com>
> > Cc: users at ovirt.org
> > Sent: Wednesday, December 31, 2014 11:59:57 PM
> > Subject: Re: [ovirt-users] engine-iso-uploader unexpected behaviour
> (steve a)
> >
> > ----- Original Message -----
> > > From: "Steve Atkinson" <satkinson at telvue.com>
> > > To: "Yedidyah Bar David" <didi at redhat.com>
> > > Cc: users at ovirt.org
> > > Sent: Wednesday, December 31, 2014 11:18:39 PM
> > > Subject: Re: [ovirt-users] engine-iso-uploader unexpected behaviour
> (steve
> > > a)
> > >
> > > in our case our nas doesn't support scp but that no fault of the the
> > > manager.
> > >
> > > I was mentioning more specifically that the --nfs-server method seemed
> to
> > > throw an error on an undefined attribute 'domaintype' that is not
> something
> > > that can be supplied in the config file or passed as an argument. the
> out
> > > put from the the debug is further up in my first email.
> >
> > Sorry.
> >
> > You wrote:
> > > Alternatively, using engine-iso-uploader --nfs-server=[path] upload
> [iso]
> > > --verbose returns the following error:
> > >
> > > ERROR: local variable 'domain_type' referenced before assignment
> > > INFO: Use the -h option to see usage.
> > > DEBUG: Configuration:
> > > DEBUG: command: upload
> > > DEBUG: Traceback (most recent call last):
> > > DEBUG: File "/usr/bin/engine-iso-uploader", line 1440, in <module>
> > > DEBUG: isoup = ISOUploader(conf)
> > > DEBUG: File "/usr/bin/engine-iso-uploader", line 455, in __init__
> > > DEBUG: self.upload_to_storage_domain()
> > > DEBUG: File "/usr/bin/engine-iso-uploader", line 1089, in
> > > upload_to_storage_domain
> > > DEBUG: elif domain_type in ('localfs', ):
> > > DEBUG: UnboundLocalError: local variable 'domain_type' referenced
> before
> > > assignment
> >
> > That's indeed a bug. Now pushed a one-line fix [1]. If you can, please
> > try and it report. Thanks!
> >
> > [1] http://gerrit.ovirt.org/36499
>
> It will fail for you, though - it simply tries to mount directly, and as
> you
> said, your engine can't access your storage network. But hopefully fail
> with
> some nicer error message.
>
> Best,
> --
> Didi
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/users/attachments/20150105/d34fe39d/attachment.html>