[ovirt-users] bug in disks QOS

[Roy Golan]

On Fri, Mar 25, 2016 at 12:22 PM, Fabrice Bacchella <
fabrice.bacchella at orange.fr> wrote:

> I attached a image disk to a VM , but set it using the wrong disk profile,
> I powered off the VM, and then tried to change it on the GUI.
>
> The operation in the GUI is ok.
>
> Need more of the log if you don't see the profiles changing. Please share
a bigger w or the whole log.



But nothing is done.
>
> And in the log I get:
> 2016-03-25 10:12:10,467 INFO
> [org.ovirt.engine.core.bll.UpdateVmDiskCommand] (default task-26) [2f3b7d9]
> Lock Acquired to object 'EngineLock:{exclusiveLocks='null',
> sharedLocks='[a32e1043-a5a5-4e4c-8436-f7b7a4ff644c=<VM,
> ACTION_TYPE_FAILED_VM_IS_LOCKED>]'}'
> 2016-03-25 10:12:10,608 INFO
> [org.ovirt.engine.core.bll.UpdateVmDiskCommand] (default task-26) [2f3b7d9]
> Running command: UpdateVmDiskCommand internal: false. Entities affected :
> ID: 55d2be6b-7a78-4712-82be-b725b7812db8 Type: DiskAction group
> EDIT_DISK_PROPERTIES with role type USER
> 2016-03-25 10:12:10,794 INFO
> [org.ovirt.engine.core.bll.UpdateVmDiskCommand] (default task-26) [2f3b7d9]
> Lock freed to object 'EngineLock:{exclusiveLocks='null',
> sharedLocks='[a32e1043-a5a5-4e4c-8436-f7b7a4ff644c=<VM,
> ACTION_TYPE_FAILED_VM_IS_LOCKED>]'}'
> 2016-03-25 10:12:10,808 INFO
> [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector]
> (default task-26) [2f3b7d9] Correlation ID: 2f3b7d9, Call Stack: null,
> Custom Event ID: -1, Message: VM test test_Disk3 disk was updated by
> FA4 at apachesso.
>
>
> It says "with role type USER" but I'm logged as a super admin
>
>
I know its confusing a bit.

The RoleType is an indirect property of an action, in that case
UpdateVmDisk. Every action has an ActionGroup, and each Action has a
RoleType, and this is used to allow/prevent or display behaviour.

So looking at VdcActionType.java and ActionGroup.java, you can see the
declaration.

VdcActionType.java

UpdateVmDisk(34, ActionGroup.CONFIGURE_VM_STORAGE, false,
QuotaDependency.STORAGE),

ActionGroup.java

CONFIGURE_VM_STORAGE(10, RoleType.USER, true, ApplicationMode.VirtOnly),




The set up is totally new, on dedicated centos 7.2, running
> 3.6.3.4-1.el7.centos.
>
>
>
> _______________________________________________
> Users mailing list
> Users at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/users/attachments/20160327/cf8f3033/attachment-0001.html>