[ovirt-devel] AppErrors.properties merged together

[Vojtech Szocs]

Hi Jakub, thanks for taking the effort to simplify AppErrors handling!

The AppErrors.properties file and its localized variants should live in a
single location, e.g. frontend/webadmin/modules/frontend. We should avoid
having multiple AppErrors.properties copies spread across the codebase.

The backend dal (data access layer) module has its own copy of
AppErrors.properties file. One option is to copy it from the source
location during Engine build, another option is to simply use symlinks.

In any case, there should be a unit test that ensures all EngineMessage
enum members are reflected as methods in AppErrors interface. This will
give us the confidence that backend EngineMessage's have proper strings
associated with them.

Regards,
Vojtech


On Mon, Jun 12, 2017 at 8:51 PM, Jakub Niedermertl <jniederm at redhat.com>
wrote:

> Hi all,
>
> there is a patch [1] removing `AppErrors.properties` from webadmin project
> to simplify edits of AppErrors/EngineMessage. AppErrors.properties from
> webadmin project will be merged to AppErrors.properties in frontend
> project. This requires some manual resolutions of conflicts of translation
> values.
>
> I'd like to kindly ask you to review altered translation values. They are
> mostly just typos.
>
> Thanks.
> Jakub
>
> [1]: https://gerrit.ovirt.org/#/c/76215/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170613/b4066e04/attachment-0001.html>