About merging patches without tests

Sandro Bonazzola sbonazzo at redhat.com
Fri May 16 07:33:44 UTC 2014


Il 15/05/2014 18:46, David Caro ha scritto:
> Hi!
> 
> From time to time we have some patches that are merged to master branches
> without having been tested mostly because the developer merges before having any
> response from the jenkins system.
> 
> Merging one of those patches makes any following test run on that branch to
> fail, and creating a lot of noise and trouble around all patches and jobs.
> 
> So I wanted to stat a little discussion to bring up ideas on how to prevent
> that. Some random thoughts:
> 
> * -1 the patch at jenkins job start, and reset to 0 on success or infra failure,
> and keep -1 if jenkins failure
> * Only send a message to the patch with 'jenkins jobs started'

I think that something like "jenkins jobs started, please don't merge until they finish" should be enough.

> * Setup zuul as gateway, and make it block the patches if they do not pass the tests
> 
> 
> 
> Cheers!
> 
> 
> 
> _______________________________________________
> Infra mailing list
> Infra at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
> 


-- 
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com



More information about the Infra mailing list