Re: [Engine-devel] CodeQuality/Automated Checking
----- Original Message -----
From: "Eli Mesika" <emesika(a)redhat.com>
To: "Sven Kieske" <S.Kieske(a)mittwald.de>
Cc: engine-devel(a)ovirt.org
Sent: Thursday, December 12, 2013 1:10:20 PM
Subject: Re: [Engine-devel] CodeQuality/Automated Checking
----- Original Message -----
> From: "Sven Kieske" <S.Kieske(a)mittwald.de>
> To: engine-devel(a)ovirt.org
> Sent: Thursday, December 12, 2013 10:14:16 AM
> Subject: [Engine-devel] CodeQuality/Automated Checking
>
> Hi,
>
> I just stumbled upon this:
>
> http://gerrit.ovirt.org/#/c/22310/1/vdsm.spec.in
>
> such errors could be prevented easily.
> either by using bash -n $scriptname.sh before commit
> or by automated syntaxchecking via jenkins ?
+1
first, using bash is not a good idea... better to use POSIX compliant shell.
second, these changes should be part of Makefile just like we validate python scripts.
I can workout some patch to do this.
>
> what do you think?
> --
> Mit freundlichen Grüßen / Regards
>
> Sven Kieske
>
> Systemadministrator
> Mittwald CM Service GmbH & Co. KG
> Königsberger Straße 6
> 32339 Espelkamp
> T: +49-5772-293-100
> F: +49-5772-293-333
> https://www.mittwald.de
> Geschäftsführer: Robert Meyer
> St.Nr.: 331/5721/1033, USt-IdNr.: DE814773217, HRA 6640, AG Bad Oeynhausen
> Komplementärin: Robert Meyer Verwaltungs GmbH, HRB 13260, AG Bad Oeynhausen
> _______________________________________________
> Engine-devel mailing list
> Engine-devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/engine-devel
>
_______________________________________________
Engine-devel mailing list
Engine-devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-devel