6:17 p.m.
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Doron Fediuck" <dfediuck(a)redhat.com>
Cc: "Giuseppe Vallarelli" <gvallare(a)redhat.com>, engine-devel(a)ovirt.org
Sent: Wednesday, June 12, 2013 3:59:43 PM
Subject: Re: [Engine-devel] Add traffic shaping parameters for a network interface.
On Wed, Jun 12, 2013 at 06:54:52AM -0400, Doron Fediuck wrote:
>
>
> ----- Original Message -----
> > From: "Giuseppe Vallarelli" <gvallare(a)redhat.com>
> > To: "Doron Fediuck" <dfediuck(a)redhat.com>
> > Cc: engine-devel(a)ovirt.org
> > Sent: Wednesday, June 12, 2013 1:47:03 PM
> > Subject: Re: [Engine-devel] Add traffic shaping parameters for a network
> > interface.
> >
> > ----- Original Message -----
> > | From: "Giuseppe Vallarelli" <gvallare(a)redhat.com>
> > | To: "Doron Fediuck" <dfediuck(a)redhat.com>
> > | Cc: engine-devel(a)ovirt.org
> > | Sent: Wednesday, June 12, 2013 9:28:19 AM
> > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > | network
> > | interface.
> > |
> > |
> > |
> > | ----- Original Message -----
> > | | From: "Doron Fediuck" <dfediuck(a)redhat.com>
> > | | To: "Giuseppe Vallarelli" <gvallare(a)redhat.com>
> > | | Cc: "Livnat Peer" <lpeer(a)redhat.com>,
engine-devel(a)ovirt.org, "Dan
> > | | Kenigsberg" <danken(a)redhat.com>
> > | | Sent: Wednesday, June 12, 2013 9:05:35 AM
> > | | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > | | network
> > | | interface.
> > | |
> > | |
> > | |
> > | | ----- Original Message -----
> > | | > From: "Giuseppe Vallarelli" <gvallare(a)redhat.com>
> > | | > To: "Livnat Peer" <lpeer(a)redhat.com>
> > | | > Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
engine-devel(a)ovirt.org,
> > | | > "Dan
> > | | > Kenigsberg" <danken(a)redhat.com>
> > | | > Sent: Tuesday, June 11, 2013 5:34:16 PM
> > | | > Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > | | > network
> > | | > interface.
> > | | >
> > | | > ----- Original Message -----
> > | | > | From: "Giuseppe Vallarelli" <gvallare(a)redhat.com>
> > | | > | To: "Livnat Peer" <lpeer(a)redhat.com>
> > | | > | Cc: "Doron Fediuck" <dfediuck(a)redhat.com>,
> > | | > | engine-devel(a)ovirt.org,
> > | | > | "Dan
> > | | > | Kenigsberg" <danken(a)redhat.com>
> > | | > | Sent: Tuesday, June 11, 2013 3:07:32 PM
> > | | > | Subject: Re: [Engine-devel] Add traffic shaping parameters for a
> > | | > | network
> > | | > | interface.
> > | | > |
> > | | > | Related to QoS parameters reporting to the engine. Looks like
> > | | > | they're
> > | | > | already
> > | | > | available, I tried to use vdsClient with list verb and I've got
> > | | > | the
> > | | > | devices
> > | | > | list where a 'specParams' is defined (it's empty because
I didn't
> > | | > | try
> > | | > | it
> > | | > | with
> > | | > | my last patch).
> > | | > |
> > | | > | devices = [... {'nicModel': 'pv', 'macAddr':
'00:1a:4a:22:3f:04',
> > | | > | 'network':
> > | | > | 'ovirtmgmt', 'alias': 'net0',
'specParams': {},
> > | | > | 'deviceId': '76173ffc-603a-496f-8ffc-31dc4d41cef6',
'address':
> > | | > | {'slot':
> > | | > | '0x03', 'bus': '0x00', 'domain':
'0x0000',
> > | | > | 'type': 'pci', 'function': '0x0'},
'device': 'bridge', 'type':
> > | | > | 'interface'}
> > | | > | ...]
> > | | > |
> > | | > | Perhaps I'm missing something, any ideas/hints ?
> > | | > | Thanks Giuseppe
> > | | >
> > | | > A few pastes:
> > | | > creating the vm: http://paste.fedoraproject.org/17953/37096041/
> > | | > dumping vm xml: http://paste.fedoraproject.org/17951/37096009/
> > | | >
> > | | > I've tried this out thanks to Toni, losing sanity with
vdsClient..
> > | | >
> > | | > Giuseppe
> > | | >
> > | |
> > | | Thanks Giuseppe.
> > | | Is this also reported by vdsm in getVmStats?
> > | |
> > |
> > | Unfortunately is not reported using getVmStats, I'm looking into it.
> > | Giuseppe
> >
> > New paste: http://paste.fedoraproject.org/18161/71033933/
(using hyperlinks instead of inlining the suggested API is unfriendly to
reviewers and to list archives)
network = {'vnet0': {'macAddr': 'D0:67:E5:F0:75:B4',
'outbound': {'average':
'1024'}, 'rxDropped': '0', 'txDropped': '0',
'inbound': {'average': '1024'},
'rxErrors': '0', 'txRate': '0.0', 'rxRate':
'0.0', 'txErrors': '0', 'state':
'unknown', 'speed': '1000', 'name': 'vnet0'}}
> >
> > Giuseppe
>
> Brilliant, thanks!
Why does it fit into getVmStats? getVmStats should report
dynamically-changing properties. Bandwidth limitations are more static
control entities, why should we report them every 10 seconds or so?
Dan
I have no problems with having it in something which runs less frequently.