1:48 p.m.
--V0207lvV8h4k8FAm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 04/14 13:44, Yaniv Kaul wrote:
On Thu, Apr 14, 2016 at 10:59 AM, Nir Soffer
<nsoffer(a)redhat.com> wrote:
=20
> On Thu, Apr 14, 2016 at 10:45 AM, Yaniv Bronheim <ybronhei(a)redhat.com>
> wrote:
> > I don't think this package is available in epel. if not, just remove =
it
> from
> > py3 list
> >
> > about why we didn't catch it in jenkins - its because I don't run
"ma=
ke
> > check" anymore over el7 to save resources. we just
build the rpm ther=
e to
> > see that we don't miss any dependencies.
> > maybe we should bring back the make check there ... what do you think?
>
> We should, make check takes about 1.5 minutes, typical build time is
> about 10 minutes
>
> fc23 build, with make check: 10:19
>
> http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/5210/c=
onsole
=20
=20
It can be drastically reduced, just by running it into RAM.
I can run both EL7 and FC23 concurrently, on my laptop, @ about 5:15. Till
they fail.
=20
EL7 make check fails on:
/usr/bin/pep8 --exclude=3D"${exclude}" --filename '*.py' . \
contrib/logdb contrib/profile-stats contrib/repoplot init/daemonAdapter
vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm
vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap
vdsm/storage/fc-scan vdsm-tool/vdsm-tool
./vdsm_hooks/checkips/after_get_stats.py:81:17: E126 continuation line
over-indented for hanging indent
./vdsm_hooks/checkips/after_get_stats.py:88:21: E126 continuation line
over-indented for hanging indent
./vdsm_hooks/checkips/after_get_stats.py:94:21: E126 continuation line
over-indented for hanging indent
make: *** [pep8] Error 1
=20
As per Yaniv's suggestion (on another thread), we are planning to set up a =
POC
on running the tests completely on RAM soon, if you have any experiences li=
ke
the one above about running the tests on ram, please put me in cc, the more
info we get the better :)
Thanks!
=20
=20
=20
=20
>
> el7 build, no make check: 11:53
> http://jenkins.ovirt.org/job/vdsm_master_check-patch-el7-x86_64/747/con=
sole
=20
=20
I'm running both EL7 and FC23 in parallel.
Y.
=20
=20
>
>
> travis build: 3-4 minutes
> https://travis-ci.org/nirs/vdsm/builds
>
> The time of the tests does not make a real difference, and we know
> that the (some) code
> works on both platforms.
>
> We should work on reducing the build time, 10 minutes for running
> tests that take
> 1.5 minutes is crazy overhead.
>
> Nir
>
> >
> > On Thu, Apr 14, 2016 at 10:26 AM, Francesco Romani <fromani(a)redhat.co=
m>
> > wrote:
> >>
> >>
> >> ________________________________
> >>
> >> From: "Sandro Bonazzola" <sbonazzo(a)redhat.com>
> >> To: "Francesco Romani" <fromani(a)redhat.com>
> >> Cc: "Eyal Edri" <eedri(a)redhat.com>, "Dan
Kenigsberg" <danken(a)redhat.=
com
> >,
> >> "devel" <devel(a)ovirt.org>, "Yaniv Bronheim"
<ybronhei(a)redhat.com>, "=
Nir
> >> Soffer" <nsoffer(a)redhat.com>
> >> Sent: Thursday, April 14, 2016 9:13:04 AM
> >>
> >> Subject: Re: [ovirt-devel] [ACTION REQUIRED]
> >> vdsm_master_build-artifacts-fc23-x86_64 is failing due to missing de=
p on
> >> fc23 .packages
> >>
> >>
> >>
> >> On Thu, Apr 14, 2016 at 9:12 AM, Sandro Bonazzola <sbonazzo(a)redhat.c=
om>
> >> wrote:
> >>>
> >>>
> >>>
> >>> On Thu, Apr 14, 2016 at 9:01 AM, Francesco Romani <fromani(a)redhat.c=
om>
> >>> wrote:
> >>>>
> >>>>
> >>>>
> >>>> ________________________________
> >>>>
> >>>> From: "Eyal Edri" <eedri(a)redhat.com>
> >>>> To: "Sandro Bonazzola" <sbonazzo(a)redhat.com>
> >>>> Cc: "Dan Kenigsberg" <danken(a)redhat.com>,
"devel" <devel(a)ovirt.org=
,
> >>>> "Yaniv Bronheim" <ybronhei(a)redhat.com>, "Nir
Soffer" <
> nsoffer(a)redhat.com>,
> >>>> "Francesco Romani" <fromani(a)redhat.com>
> >>>> Sent: Thursday, April 14, 2016 8:54:50 AM
> >>>> Subject: Re: [ovirt-devel] [ACTION REQUIRED]
> >>>> vdsm_master_build-artifacts-fc23-x86_64 is failing due to missing =
dep
> on
> >>>> fc23 .packages
> >>>>
> >>>>
> >>>> Don't we run it per patch as well?
> >>>> How did it got merged?
> >>>>
> >>>> On Apr 14, 2016 9:42 AM, "Sandro Bonazzola"
<sbonazzo(a)redhat.com>
> wrote:
> >>>>>
> >>>>>
> >>>>>
> http://jenkins.ovirt.org/job/vdsm_master_build-artifacts-fc23-x86_64/82=
3/console
> >>>>>
> >>>>> 00:05:46.751
> >>>>>
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> >>>>> 00:05:46.751 ERROR: Failure: ImportError
(No module named 'netadd=
r')
> >>>>> 00:05:46.751
> >>>>>
> ----------------------------------------------------------------------
> >>>>> 00:05:46.752 Traceback (most recent call last):
> >>>>> 00:05:46.752 File
> "/usr/lib/python3.4/site-packages/nose/failure.py",
> >>>>> line 39, in runTest
> >>>>> 00:05:46.752 raise self.exc_val.with_traceback(self.tb)
> >>>>> 00:05:46.752 File
> "/usr/lib/python3.4/site-packages/nose/loader.py",
> >>>>> line 418, in loadTestsFromName
> >>>>> 00:05:46.752 addr.filename, addr.module)
> >>>>> 00:05:46.752 File
> >>>>> "/usr/lib/python3.4/site-packages/nose/importer.py",
line 47, in
> >>>>> importFromPath
> >>>>> 00:05:46.752 return self.importFromDir(dir_path, fqname)
> >>>>> 00:05:46.752 File
> >>>>> "/usr/lib/python3.4/site-packages/nose/importer.py",
line 94, in
> >>>>> importFromDir
> >>>>> 00:05:46.753 mod =3D load_module(part_fqname, fh, filename,
d=
esc)
> >>>>> 00:05:46.753 File
"/usr/lib64/python3.4/imp.py", line 235, in
> >>>>> load_module
> >>>>> 00:05:46.753 return load_source(name, filename, file)
> >>>>> 00:05:46.753 File "/usr/lib64/python3.4/imp.py",
line 171, in
> >>>>> load_source
> >>>>> 00:05:46.753 module =3D methods.load()
> >>>>> 00:05:46.753 File "<frozen
importlib._bootstrap>", line 1220, in
> load
> >>>>> 00:05:46.753 File "<frozen
importlib._bootstrap>", line 1200, in
> >>>>> _load_unlocked
> >>>>> 00:05:46.753 File "<frozen
importlib._bootstrap>", line 1129, in
> >>>>> _exec
> >>>>> 00:05:46.753 File "<frozen
importlib._bootstrap>", line 1471, in
> >>>>> exec_module
> >>>>> 00:05:46.754 File "<frozen
importlib._bootstrap>", line 321, in
> >>>>> _call_with_frames_removed
> >>>>> 00:05:46.754 File
> >>>>>
> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/r=
pmbuild/BUILD/vdsm-4.17.999/tests/network/models_test.py",
> >>>>> line 27, in <module>
> >>>>> 00:05:46.754 from vdsm.netinfo import bonding, mtus
> >>>>> 00:05:46.754 File
> >>>>>
> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/r=
pmbuild/BUILD/vdsm-4.17.999/lib/vdsm/netinfo/__init__.py",
> >>>>> line 26, in <module>
> >>>>> 00:05:46.754 from .ipwrapper import DUMMY_BRIDGE
> >>>>> 00:05:46.755 File
> >>>>>
> "/home/jenkins/workspace/vdsm_master_build-artifacts-fc23-x86_64/vdsm/r=
pmbuild/BUILD/vdsm-4.17.999/lib/vdsm/ipwrapper.py",
> >>>>> line 30, in <module>
> >>>>> 00:05:46.755 from netaddr.core import AddrFormatError
> >>>>> 00:05:46.755 ImportError: No module named 'netaddr'
> >>>>>
> >>>>>
> >>>>>
> >>>>> Please fix ASAP.
> >>>>
> >>>>
> >>>> I think this a jenkins failure, because this seems to come from (l=
ack
> >>>> of) netaddr package, which is an external
package Vdsm depends on
> since ages
> >>>> (late 2013!)
> >>>
> >>>
> >>> I think it's a missing dep in build-artifacts.packages
> >>
> >>
> >> forgot to mention, please note it's the python3 package missing.
> >>
> >>
> >> yep, I think you are right. Most likely broken by
> >> https://gerrit.ovirt.org/#/c/55896/
> >>
> >> Let me quickly post a patch for this.
> >>
> >> Bests,
> >>
> >>
> >> --
> >> Francesco Romani
> >> RedHat Engineering Virtualization R & D
> >> Phone: 8261328
> >> IRC: fromani
> >
> >
> >
> >
> > --
> > Yaniv Bronhaim.
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
IRC: dcaro|dcaroest@{freenode|oftc|redhat}
Web: www.redhat.com
RHT Global #: 82-62605
--V0207lvV8h4k8FAm
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJXD3WXAAoJEEBxx+HSYmnDHqkH+gKUMyUojL/bBXM37UvyJUOa
EyxxgqOPiMXDC3qgIULGwzmEZm4Hi9AfGfXr1WZypgB5XLu8RKs18dNIl4yjPNwX
IV1rMgaiw2r2josr0T5KlUr948u1uxCc3mo4wiB3FuS9oYyUglnQgWafy3Gk+9SM
5HFuhq3C6EOrJe3QpVrK7W1DYaX9Sup2pzkyF5ckqb9xaMvyVkNebBYuSdtza/Kl
nOV1aWI5whv8YnWTLAg9JlSVkcuRj4/5Hsvgng/xBK+jad2jGdcDSKwa7BQFlSPz
nHYKZMSxUZayS43M+/2xYKzREmQR7lYM+9DA5HdHf2zHGpRtLD0zHmtzI30kYp0=
=fB7j
-----END PGP SIGNATURE-----
--V0207lvV8h4k8FAm--