[ovirt-devel] Re: vdsm pylint runs don't report some errors
On Mon, Sep 13, 2021 at 4:02 PM Harel Braha <hbraha(a)redhat.com> wrote:
Hi,
When I ran vdsm linters in my local environment, I received errors such as:
` lib/vdsm/storage/lvm.py:1837:14: E1120: No value for argument 'rc' in
constructor call (no-value-for-parameter)`
On inspection of the CI logs from other runs, we found an internal Pylint error[1].
It appears that this error prevents Pylint from working properly.
As a result of bumping up pylint version in order to overcome this error,
we got the same errors as in my local environment [2], and another error that seems to be
a false positive:
`lib/vdsm/storage/volumemetadata.py:101:29: E1102: validate is not callable
(not-callable)`
We don't have a path in the tests that would reach the code part that
raises the problematic exception[3], but it seems legit.
You can send a patch to use more recent version of pylint.
We pin the version to avoid random failures when pylint changes the rules
so we need to update the pinned version from time to time.