[ovirt-devel] Re: Change in ovirt-engine[master]: packaging: engine-setup: Use otopi's checkForSafeUpdate
On Wed, Jan 12, 2022 at 12:06 PM Code Review <gerrit(a)ovirt.org> wrote:
From Jenkins CI <jenkins(a)ovirt.org>:
Jenkins CI has posted comments on this change. (
https://gerrit.ovirt.org/c/ovirt-engine/+/116920 )
Change subject: packaging: engine-setup: Use otopi's checkForSafeUpdate
......................................................................
Patch Set 6:
Build Failed
https://jenkins.ovirt.org/job/standard-enqueue/36418/ :
This change was not submitted to any change queues for system testing. You will need to
create some 'build-artifacts' jobs if you want changes to be submitted to change
queues, take part in the system tests and be deployed to the nightly snapshot
repositories. If your project uses STDCI V2 and you have release branches configured, you
may disregard this message.
https://jenkins.ovirt.org/job/ovirt-engine_standard-on-merge/2762/ : UNSTABLE
I think it's because of:
[2022-01-12T09:42:30.703Z] Traceback (most recent call last):
[2022-01-12T09:42:30.703Z] File
"/home/jenkins/agent/workspace/ovirt-engine_standard-on-merge(a)tmp/durable-ecea2c02/script.sh",
line 10, in <module>
[2022-01-12T09:42:30.703Z] change = GerritMergedChange.from_jenkins_env()
[2022-01-12T09:42:30.703Z] File
"/home/jenkins/agent/workspace/ovirt-engine_standard-on-merge/jenkins/stdci_libs/change_queue/changes/__init__.py",
line 290, in from_jenkins_env
[2022-01-12T09:42:30.703Z] o =
cls(gerrit_patchset=GerritPatchset.from_jenkins_env())
[2022-01-12T09:42:30.703Z] File
"/home/jenkins/agent/workspace/ovirt-engine_standard-on-merge/jenkins/stdci_libs/gerrit.py",
line 157, in from_jenkins_env
[2022-01-12T09:42:30.703Z] 'GERRIT_PATCHSET_UPLOADER', env
[2022-01-12T09:42:30.703Z] File
"/home/jenkins/agent/workspace/ovirt-engine_standard-on-merge/jenkins/stdci_libs/gerrit.py",
line 97, in from_jenkins_env
[2022-01-12T09:42:30.703Z] return cls(env[prefix + '_NAME'],
env[prefix + '_EMAIL'])
[2022-01-12T09:42:30.703Z] File "/usr/lib64/python3.6/os.py", line
669, in __getitem__
[2022-01-12T09:42:30.703Z] raise KeyError(key) from None
[2022-01-12T09:42:30.703Z] KeyError: 'GERRIT_PATCHSET_UPLOADER_NAME'
and I *think* it's because I commented 'ost check' on two patches,
which were one above the other, and CI merged the upper one before
finishing the gating of the lower one (current).
Current case can most probably be ignored, but I wonder if we want to
do something in the general case - perhaps the code already does
everything well, didn't check - e.g. checking that all pending patches
in the stack have all acks, etc.
Best regards,
--
Didi