1:18 a.m.
----- Original Message -----
From: "Einav Cohen" <ecohen(a)redhat.com>
To: "Malini Rao" <mrao(a)redhat.com>, "Eldan Hildesheim"
<info(a)eldanet.com>, "Eldan Hildesheim" <ehildesh(a)redhat.com>
Cc: "Tomas Jelinek" <tjelinek(a)redhat.com>, derez(a)redhat.com,
"engine-devel" <engine-devel(a)ovirt.org>
Sent: Wednesday, May 29, 2013 12:53:47 AM
Subject: static header only in VM dialog?
when reviewing the code for the "redesign of vm related dialogs", Daniel has
raised an interesting question: Why do we want the static header only in VM
dialog?
(I assume that he refers to the top section of the New VM dialog as seen in
[1], which
contains the DC/Cluster, Quota, etc information, and is "static", i.e., it is
always
displayed, regardless of the selected side-tab within the dialog)
I agree with what Daniel is implying here: for consistency, we would probably
want to
introduce this static header to other dialogs, at least to the ones that also
contain
side-tabs in which it makes sense to turn the "header" to static
[e.g.
"New Host" (which contains a DC + Cluster "header") - see
http://oi39.tinypic.com/2z84xnp.jpg,
"New Cluster" (which contains a DC "header") - see
http://oi40.tinypic.com/2vmyj2x.jpg]
[I assume, of course, that all the VM-like dialogs (e.g. New/Edit VM-Pool)
will also have
static headers - I don't know if the patch already takes care of that or not]
Thoughts?
[@Daniel - if you had something else in mind, and/or other dialogs in mind -
please feel free
to add/amend/etc]
Besides consistency matters, I wanted to understand what's the motivation of
keeping these widgets static. I.e. is it an essential preparation for the new
instance type dialog or a new concept for tab based dialogs
(as DC/Cluster values aren't necessarily relevant for each tab in the dialog)
----
Thanks,
Einav
[1] http://www.ovirt.org/images/9/9e/Instance_type.pdf
----- Original Message -----
> From: derez(a)redhat.com
> To: "Tomas Jelinek" <tjelinek(a)redhat.com>
> Cc: "Vojtech Szocs" <vszocs(a)redhat.com>, "Einav Cohen"
<ecohen(a)redhat.com>,
> "Frank Kobzik" <fkobzik(a)redhat.com>,
> "Eldan Hildesheim" <info(a)eldanet.com>
> Sent: Tuesday, May 28, 2013 5:05:38 PM
> Subject: Change in ovirt-engine[master]: userportal,webadmin: redesign of
> vm related dialogs
>
> Daniel Erez has posted comments on this change.
>
> Change subject: userportal,webadmin: redesign of vm related dialogs
> ......................................................................
>
>
> Patch Set 5: (1 inline comment)
>
> Code looks good.
> A few questions regarding the design:
> 1. Why do we want the static header only in VM dialog?
> 2. DC/Host are really relevant for all tabs?
> 3. Is it just a preparation for the final instance type dialog?
> 4. If it's indeed merely preparation, shouldn't it be merged only once we
> have the full picture of the new dialog?
>
> ....................................................
> File
>
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
> Line 21:
> Line 22: .header {
> Line 23: background-color: #D3D3D3;
> Line 24: border-bottom: 1px solid #CED8DF;
> Line 25: margin-bottom: 15px;
> is it supposed to be that large?
> Line 26: padding-top: 6px;
> Line 27: margin-top: 4px;
> Line 28: margin-right: 3px;
> Line 29: display: none;
>
>
> --
> To view, visit http://gerrit.ovirt.org/14635
> To unsubscribe, visit http://gerrit.ovirt.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Icad8098e286f821da25fac22fd0a840a42f105c9
> Gerrit-PatchSet: 5
> Gerrit-Project: ovirt-engine
> Gerrit-Branch: master
> Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
> Gerrit-Reviewer: Eldan Hildesheim <info(a)eldanet.com>
> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
>