Hi, Martin and Ondra,
I just tried but found that after adding the missing out parameter of `job`
for gluster volume rebalance method in API model, the sdk generators always
failed to run `mvn package` and had an error like "duplicated definitions
for the job attribute".
After diving into the API model/metamodel, probably the cause is:
* The `Action` is a built-in model defined in [1] in API metamodel, instead
of API model traditionally.
* The `job` attribute has been explicitly added in `Action`.
* All the input/output parameters of all the action methods are also added
as the attributes of `Action`.
So after I added a extra out job parameters, there would have two job
attributes in the generated `types.Action`, as well as the reader/writer
generated for `Action`. Basically, I think the sdks themselves
are responsible to handle this, maybe it's reasonable to return a full
action object here.
If I'am wrong or miss something, please let me know, thanks so much.
[1]:
https://github.com/oVirt/ovirt-engine-api-metamodel/blob/master/tool/src/...
On Mon, Aug 20, 2018 at 3:06 PM Martin Perina <mperina(a)redhat.com> wrote:
On Sun, Aug 19, 2018 at 4:15 PM, iterjpnic <majunjiev(a)gmail.com> wrote:
> Hi,
>
> From my perspective, adding an out Action parameter in API model may
> significantly affect current implementations. I commit a patch [1], that
> return the full action object when member is None, into ovirt-engine-sdk
> project.
>
Ondro, could you please review the patch?
>
> If possible, could anybody tell me the way to trigger the CI in gerrit,
> great thanks. :)
>
Please take a look at below thread:
https://lists.ovirt.org/pipermail/devel/2017-February/029630.html
>
> [1]:
https://gerrit.ovirt.org/#/c/93798/
> _______________________________________________
> Devel mailing list -- devel(a)ovirt.org
> To unsubscribe send an email to devel-leave(a)ovirt.org
> Privacy Statement:
https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
>
https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
>
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/KPRC3VY5EER...
>
--
Martin Perina
Associate Manager, Software Engineering
Red Hat Czech s.r.o.