----- Original Message -----
From: "Nir Soffer" <nsoffer(a)redhat.com>
To: "Sven Kieske" <S.Kieske(a)mittwald.de>
Cc: devel(a)ovirt.org
Sent: Wednesday, June 25, 2014 4:48:40 PM
Subject: Re: [ovirt-devel] multipath configuration
----- Original Message -----
> From: "Sven Kieske" <S.Kieske(a)mittwald.de>
> To: devel(a)ovirt.org
> Sent: Wednesday, June 25, 2014 5:32:47 PM
> Subject: Re: [ovirt-devel] multipath configuration
>
> Am 25.06.2014 15:58, schrieb Yeela Kaplan:
> > Hi,
> >
> > Currently multipath.conf is being rotated each time we reconfigure it.
> >
> > We'd like to change the behaviour for multipath.conf so that current
> > configuration will be commented out
> > and we'd stop rotating (in the same manner as libvirt conf works today).
> >
> > Does anybody have any comment for/ against?
> >
> > Thanks in advance,
> > Yeela
>
>
> I never looked into this, but as I read this
> I have to shout out: this is a bad practice!
>
> you should not just comment out old config and write
> new config to the same file!
>
> you should instead implement a proper rotation
> algorithm, because you can than easily fall back
> onto older configuration, plus you just got
> your configuration in a simple version control system.
How do you suggest to rotate configuration files?
Can you give an example project which does this right?
A cleaner way for doing this would be using augeas [1] (especially in
the libvirt configuration case). I don't know what's its current status
of support for the multipath configuration.
Anyway if we want to pursue the current method I think that parsing,
commenting and editing multipath.conf automatically is harder than
libvirt.conf (e.g. it contains sections, etc.)
[1]
http://augeas.net
--
Federico