Re: [ovirt-devel] Ending support for 3.x engines on master
On Sun, Jun 19, 2016 at 4:00 PM, Yaniv Dary <ydary(a)redhat.com> wrote:
What is the cost of keeping them?
Hard to tell, I guess each time you touch code related to the api,
your effort is
doubled.
Yaniv Dary
Technical Product Manager
Red Hat Israel Ltd.
34 Jerusalem Road
Building A, 4th floor
Ra'anana, Israel 4350109
Tel : +972 (9) 7692306
8272306
Email: ydary(a)redhat.com
IRC : ydary
On Sun, Jun 19, 2016 at 3:40 PM, Dan Kenigsberg <danken(a)redhat.com> wrote:
>
> On Sun, Jun 19, 2016 at 02:13:40PM +0300, Nir Soffer wrote:
> > Hi all,
> >
> > We should not support now Engine 3.5 with ovirt 4.0, but vdsm still
> > accept 3.5 engines - I guess we forgot to disable it in 4.0.
>
> Correct. There was a moment in time where we considered supporting 3.5
> as well.
>
> >
> > In 4.1, I don't think we should support any 3.x Engine - otherwise we
> > will have to waste time maintaining old apis and infrastructure, instead
> > of adding new features that matter to our users.
>
> Do you have a list of old APIs you'd like to throw away? We've killed a
> few in 4.0, and
> $ git grep REQUIRED_FOR
> is not huge.
>
> >
> > I suggest we disable now support for 3.x engines.
> >
> > Please see Eli patch:
> > https://gerrit.ovirt.org/59308
> >
> > Thoughts?
>
> +1, but let's see if ydary/mgoldboi think we should keep 3.6.