9:27 a.m.
This is a multi-part message in MIME format.
--------------9B509B7F260CB83D72369B8B
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
On 11/23/2017 04:23 PM, Nir Soffer wrote:
On Thu, Nov 23, 2017 at 4:55 PM Dan Kenigsberg <danken(a)redhat.com
<mailto:danken@redhat.com>> wrote:
On Thu, Nov 23, 2017 at 4:03 PM, Nir Soffer <nsoffer(a)redhat.com
<mailto:nsoffer@redhat.com>> wrote:
> On Thu, Nov 23, 2017 at 3:59 PM Dan Kenigsberg
<danken(a)redhat.com <mailto:danken@redhat.com>> wrote:
>>
>> On Thu, Nov 23, 2017 at 1:56 PM, Nir Soffer <nsoffer(a)redhat.com
<mailto:nsoffer@redhat.com>> wrote:
>> > On Thu, Nov 23, 2017 at 1:51 PM Edward Haas <ehaas(a)redhat.com
<mailto:ehaas@redhat.com>> wrote:
>> >>
>> >> Per what I see, all CI jobs on vdsm/fc27 fail.
>> >> This is the second time this week, please consider reverting.
>> >>
>> >> We should try to avoid such changed before the weekend
>> >
>> >
>> > Some of the failures like
>> >
>> >
http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc27-x86_64/100/console
>> >
>> > Should be fixed by:
>> > https://gerrit.ovirt.org/84569/
>> >
>> > I have see some network test failing when running mock_runner
locally,
>> > you may need to mark them as broken on fc27.
>>
>> We have a busy couple of weeks until release of ovirt-4.2.0. As
much
>> as I like consuming Fedora early, I'm not sure that enabling so
close
>> to the release was a good idea. Nothing forces us to do it now (and
>> there are a lot of reasons to do it later). Let's give it
another go,
>> but let us not keep it on the red for the weekend.
>
>
> I'm happy with the storage code being tested on current fedora.
I'm more than happy. I'm thrilled to for it to be tested and run.
I am not happy to give a vote to a job that was never ever successful.
The job is successful, some tests or maybe the code they test need work.
This is why we have skipif/xfail and broken_on_ci.
>
> Please make sure the few failing network tests are not breaking
the build.
It's probably time to mark the tests that use loseup as
broken-on-jenkins
loop devices are usually ok on jenkins. We have several tests in
storage using
them and I don't know about any failures. For example
storage/blockdev_test.py.
Francesco, do you want to mark them as broken for now?
Yes, because we don't have resource to spare to properly fix the tests.
Hopefully next week.
Bests,
--
Francesco Romani
Senior SW Eng., Virtualization R&D
Red Hat
IRC: fromani github: @fromanirh
--------------9B509B7F260CB83D72369B8B
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 11/23/2017 04:23 PM, Nir Soffer wrote:<br>
<blockquote type="cite"
cite="mid:CAMRbyyuf3GndzWpCpmp0kkGKx=TbkLYGSN1b-V86d3RnT7NStA@mail.gmail.com">
<div dir="ltr"><br>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Nov 23, 2017 at 4:55 PM Dan Kenigsberg
<<a href="mailto:danken@redhat.com"
moz-do-not-send="true">danken(a)redhat.com</a>&gt;
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu,
Nov 23, 2017 at 4:03 PM, Nir Soffer <<a
href="mailto:nsoffer@redhat.com" target="_blank"
moz-do-not-send="true">nsoffer(a)redhat.com</a>&gt;
wrote:<br>
> On Thu, Nov 23, 2017 at 3:59 PM Dan Kenigsberg <<a
href="mailto:danken@redhat.com" target="_blank"
moz-do-not-send="true">danken(a)redhat.com</a>&gt;
wrote:<br>
>><br>
>> On Thu, Nov 23, 2017 at 1:56 PM, Nir Soffer <<a
href="mailto:nsoffer@redhat.com" target="_blank"
moz-do-not-send="true">nsoffer(a)redhat.com</a>&gt;
wrote:<br>
>> > On Thu, Nov 23, 2017 at 1:51 PM Edward Haas
<<a href="mailto:ehaas@redhat.com"
target="_blank"
moz-do-not-send="true">ehaas(a)redhat.com</a>&gt;
wrote:<br>
>> >><br>
>> >> Per what I see, all CI jobs on vdsm/fc27
fail.<br>
>> >> This is the second time this week, please
consider reverting.<br>
>> >><br>
>> >> We should try to avoid such changed before
the weekend<br>
>> ><br>
>> ><br>
>> > Some of the failures like<br>
>> ><br>
>> > <a
href="http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc27-x86_...
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://jenkins.ovirt.org/job/vdsm_mas...
>> ><br>
>> > Should be fixed by:<br>
>> > <a
href="https://gerrit.ovirt.org/84569/"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://gerrit.ovirt.org/84569/</a...
>> ><br>
>> > I have see some network test failing when
running mock_runner locally,<br>
>> > you may need to mark them as broken on
fc27.<br>
>><br>
>> We have a busy couple of weeks until release of
ovirt-4.2.0. As much<br>
>> as I like consuming Fedora early, I'm not sure that
enabling so close<br>
>> to the release was a good idea. Nothing forces us
to do it now (and<br>
>> there are a lot of reasons to do it later). Let's
give it another go,<br>
>> but let us not keep it on the red for the weekend.<br>
><br>
><br>
> I'm happy with the storage code being tested on current
fedora.<br>
<br>
I'm more than happy. I'm thrilled to for it to be tested and
run.<br>
I am not happy to give a vote to a job that was never ever
successful.<br>
</blockquote>
<div><br>
</div>
<div>The job is successful, some tests or maybe the code they
test need work.</div>
<div>This is why we have skipif/xfail and broken_on_ci.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
><br>
> Please make sure the few failing network tests are not
breaking the build.<br>
<br>
It's probably time to mark the tests that use loseup as
broken-on-jenkins<br>
</blockquote>
<div><br>
</div>
<div>loop devices are usually ok on jenkins. We have several
tests in storage using</div>
<div>them and I don't know about any failures. For example
storage/blockdev_test.py.</div>
<div><br>
</div>
<div>Francesco, do you want to mark them as broken for now?</div>
</div>
</div>
</blockquote>
<br>
Yes, because we don't have resource to spare to properly fix the
tests.<br>
Hopefully next week.<br>
<br>
<br>
Bests,<br>
<pre class="moz-signature" cols="72">--
Francesco Romani
Senior SW Eng., Virtualization R&D
Red Hat
IRC: fromani github: @fromanirh</pre>
</body>
</html>
--------------9B509B7F260CB83D72369B8B--