Hi,
thank you for all the reviews!
Some patches still need some attention before we can merge the topic:
stomp: Add tests for 'Frame' class <
https://gerrit.ovirt.org/101194>
stomp: Add tests for 'Parser' <
https://gerrit.ovirt.org/101195>
py3: stomp: Overhaul 'Parser' class <
https://gerrit.ovirt.org/101114>
stomp: Fix 'COMMANDS' tuple <
https://gerrit.ovirt.org/101226>
rpc: Added 'HttpDetector' tests <
https://gerrit.ovirt.org/101227>
I also did a follow-up patch that addresses issues raised by Nir in some
of my patches:
tests: Stomp-related test improvements <
https://gerrit.ovirt.org/101395>
Regards, Marcin
On 6/28/19 4:11 PM, Michal Skrivanek wrote:
> On 26 Jun 2019, at 14:53, Milan Zamazal
<mzamazal(a)redhat.com> wrote:
>
> Marcin Sobczyk <msobczyk(a)redhat.com> writes:
>
>> Hi,
>>
>> I'm currently working on making yajsonrpc/stomp implementation
>> py3-compatible so we can have basic communication with vdsm running on py3.
>> Today for the first time I was able to run vdsm [1] with py3 on fc29 and do
>> a successful 'vdsm-client Host getStats' call.
> I can add this also works for me on el8 with your patches, with both TLS
> and non-TLS configuration. Good work!
Today I got pretty far with top of Milan’s series (including Marcin’s)
on RHEL8.
Capabilities work, and after fixing up network manually (ovirtmgmt
bridge) I was able to add a Host and Activate it. Up until connecting
storage it worked fine.
>> Since these patches are needed for other teams to continue with their work
>> on py3, I'd kindly request those of you who are interested to review them:
>>
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic...
>>
>> [1] with minor tweak to 'storage.hsm' module