Re: [ovirt-devel] Failing MacPoolDaoTests on master

On 05/31 12:32, Eyal Edri wrote: > David, can you investigate? > On May 31, 2016 12:29 PM, "Roman Mohr" <rmohr(a)redhat.com&gt; wrote: > > > On Tue, May 31, 2016 at 11:21 AM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > > > they only run on changes in : > > > > > > > > **/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/** > > > **sql > > > **/backend/manager/modules/dal/** > > > > > > > So where are the jobs for for https://gerrit.ovirt.org/#/c/58328/ for > > instance? They should have been triggered, right? So, as far as I can see, the issue there is that the dao tests that failed ran on the old jenkins, and finished before the tests on the new jenkins, getting their review value overridden (as they both use the same user). One solution would be to use different gerrit users for each of the jenkins instances, though the best solution imo is to move the jobs to the new jenkins (hopefully, as part of the standard ci, work in progress, not sure of the eta) > > > > > excluding file > > > **/backend/manager/modules/dal/src/main/resources/bundles/** > > > > > > On Tue, May 31, 2016 at 12:15 PM, Roman Mohr <rmohr(a)redhat.com&gt; wrote: > > >> > > >> On Tue, May 31, 2016 at 11:12 AM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > > >> > the dao tests 4.0 are on the new jenkins and they are running: > > >> > > > >> > http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/ > > >> > http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_created/ > > >> > > > >> > > >> Am I missing somehting here? From my perspective it looks like they > > >> are never triggered. > > >> > > >> > the old one in old jenkins should be deleted. > > >> > > > >> > On Tue, May 31, 2016 at 11:57 AM, Roman Mohr <rmohr(a)redhat.com&gt; > > wrote: > > >> >> > > >> >> On Tue, May 31, 2016 at 10:49 AM, Roman Mohr <rmohr(a)redhat.com&gt; > > wrote: > > >> >> > On Tue, May 31, 2016 at 10:35 AM, Barak Korren < bkorren(a)redhat.com > > > > > >> >> > wrote: > > >> >> >>> That seems to be another issue. When building locally and on > > travis > > >> >> >>> we > > >> >> >>> have failing dao tests, not missing libraries. > > >> >> >>> > > >> >> >>> Further, on jenkins it seems like we are not running the DAO > > tests > > >> >> >>> since 26th of May. > > >> >> >>> Wrote a mail to infra list regarding that about an hour ago. > > >> >> >> > > >> >> >> Those are still running on the old Jenkins, we only created them > > on > > >> >> >> the new one for the new 4.0 branch. > > >> >> >> http://jenkins-old.ovirt.org/search/?q=dao > > >> >> > > > >> >> > Ok, the failing tests on merged master patches are there. > > >> >> > But we are not running tests on gerrit patches currently: > > >> >> > > > >> >> > > > >> >> > > > http://jenkins-old.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/ > > >> >> > > > >> >> > Were they disabled deliberately? > > >> >> > > > >> >> > > >> >> Oh that was the wrong job. So they are enabled: > > >> >> > > >> >> > > >> >> > > >> >> > > http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_created/ > > >> >> > > >> >> So maybe the issue is that the CI tests from old and new jenkins are > > >> >> overwriting their pluses and minuses? > > >> >> > > >> >> >> > > >> >> >> We are working on moving these tests into check_patch.sh so that > > we > > >> >> >> can neutralize environmental influences and stop having to give > > >> >> >> theses > > >> >> >> tests special treatment. > > >> >> >> > > >> >> >> -- > > >> >> >> Barak Korren > > >> >> >> bkorren(a)redhat.com > > >> >> >> RHEV-CI Team > > >> >> _______________________________________________ > > >> >> Devel mailing list > > >> >> Devel(a)ovirt.org > > >> >> http://lists.ovirt.org/mailman/listinfo/devel > > >> >> > > >> >> > > >> > > > >> > > > >> > > > >> > -- > > >> > Eyal Edri > > >> > Associate Manager > > >> > RHEV DevOps > > >> > EMEA ENG Virtualization R&D > > >> > Red Hat Israel > > >> > > > >> > phone: +972-9-7692018 > > >> > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > > > > > > > > > > > > > -- > > > Eyal Edri > > > Associate Manager > > > RHEV DevOps > > > EMEA ENG Virtualization R&D > > > Red Hat Israel > > > > > > phone: +972-9-7692018 > > > irc: eedri (on #tlv #rhev-dev #rhev-integ) > > > _______________________________________________ > Devel mailing list > Devel(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro(a)redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605