On Thu, Dec 20, 2018 at 10:04 AM Yedidyah Bar David <didi(a)redhat.com> wrote:
On Thu, Dec 20, 2018 at 8:49 AM Michael Burman <mburman(a)redhat.com> wrote:
>
> Hi
>
> I'm trying to update the latest master version
4.3.0-0.4.master.20181219115514.git1d803c4.el7 and on engine-setup i get:
> [ ERROR ] Failed to execute stage 'Setup validation': 'changed'
>
> 2018-12-20 08:44:50,803+0200 DEBUG otopi.context context._executeMethod:128 Stage
validation METHOD otopi.plugins.ovirt_engine_common.base.core.uninstall.Plugin._validatio
> n_changed_files
> 2018-12-20 08:44:50,819+0200 DEBUG otopi.context context._executeMethod:143 method
exception
> Traceback (most recent call last):
> File "/usr/lib/python2.7/site-packages/otopi/context.py", line 133, in
_executeMethod
> method['method']()
> File
"/usr/share/ovirt-engine/setup/bin/../plugins/ovirt-engine-common/base/core/uninstall.py",
line 247, in _validation_changed_files
> if info['changed']
> KeyError: 'changed'
> 2018-12-20 08:44:50,821+0200 ERROR otopi.context context._executeMethod:152 Failed
to execute stage 'Setup validation': 'changed'
>
> Known issue?
Thanks to Michael for letting me have a look.
It should have also failed the OST upgrade suite. Did it?
Anyway, it's my fault. I added a patch that logs a list of files
that were written by previous engine-setup runs and changed later,
probably manually by the user.
In the case I looked at on Michael's machine, this failed because
the file was missing - on upgrade from pg9.5 to 10, we remove the
9.5 copy of postgresql.conf.
I'll soon push a patch. Sorry for the noise.
This should fix:
https://gerrit.ovirt.org/96363
Best regards,
> Thanks,
>
> --
>
> Michael Burman
>
> Senior Quality engineer - rhv network - redhat israel
>
> Red Hat
>
> mburman(a)redhat.com M: 0545355725 IM: mburman
--
Didi
--
Didi