[ovirt-devel] Re: please stop merging
On Wed, Feb 12, 2020 at 5:03 PM Martin Perina <mperina(a)redhat.com> wrote:
Hi,
I'm probably missing something here, so please correct me if I'm wrong:
1. CQ is running OST to detect failures and if OST will not pass, RPM with
the change will not land in tested repo, right?
unless someone manually moves packages into the tested repo - which caused
all projects to fail on engine deploy.
2. OST is still running engine on EL7, right?
yes
3. We have dropped EL7 builds from engine on Feb 6th
https://gerrit.ovirt.org/106795
So no matter what we push to engine repo, it will not pass the CQ,
because it will still be testing the old broken version (because new builds
will produce packages only for FC30 and EL8 repos). Am I right or missing
something?
Actually, engine has been failing for more then 4 weeks already on
unrelated
issues. currently its failing on a package which is deprecated
because the change has not passed CQ and the package that is tested is
based on some un-merged change. so fixing the issues now, have nothing to
do with the missing el8 packages and the longer you wait to fix the
failures, the more regressions you will introduce and harder it will be to
fix it.
At this point, I need to have patch https://gerrit.ovirt.org/#/c/106809/
run in CQ so I can see why its failing.
Right now we are doing our best to make engine running on CentOS 8 (my
personal estimation is Friday), so after that we should be able to
merge
OST patch https://gerrit.ovirt.org/106824 so OST will use EL8 for engine.
So unless I'm missing something it doesn't make sense to
block merging to
engine and its dependencies, because we need to make them running on EL8
and switch engine on EL8 in OST to unblock CQ. Am I right or am I missing
something?
lets first get to a point where we are blocked by rl8 related issues
instead of merging more changes which we later on cannot track.
Lets see what the change is failing as for now, you are blocking all other
projects (not just engine and its deps).
Regards,
Martin
On Wed, Feb 12, 2020 at 4:03 PM Dafna Ron <dron(a)redhat.com> wrote:
> Hi all,
>
> Engine has been failing for a while and someone has also moved the broken
> package manually to the tested repo which broke all projects in cq.
> At this time, until we stabilise engine and get a new package into
> tested, all projects will continue failing cq and no new packages will be
> moved to the stable repo (tested).
> if you continue to merge, we not only risk adding more regression but it
> also makes it more difficult to debug and fix as there are a lot of changes
> in the queue waiting to be tested and very little resources to run it.
>
> Please stop merging on all projects until this is resolved.
>
> Thanks,
> Dafna
>
>
>
>
--
Martin Perina
Manager, Software Engineering
Red Hat Czech s.r.o.
Attachments:
- attachment.html (text/html — 5.9 KB)