[ovirt-devel] Re: Problem with vdsm 'make check'

Yes, I didnot run make after I chnged my dev environment, It worked but I still see some commands failing namely ``` ERROR:   tests-py27: commands failed ERROR:   storage-py27: commands failed   lib-py27: commands succeeded ERROR:   network-py27: commands failed   virt-py27: commands succeeded   gluster-py27: commands succeeded ``` I am working on master. Full log here: https://pastebin.com/8RbBk97d

On Tue, Oct 15, 2019 at 5:53 PM Marcin Sobczyk <msobczyk(a)redhat.com <mailto:msobczyk@redhat.com>> wrote: On 10/15/19 2:12 PM, Kaustav Majumder wrote: > Hi, > There is no constants.py file but constants.py.in > <http://constants.py.in> -> https://pastebin.com/ATLrmTuh That would suggest that you didn't run 'make' - this is the step that generates files from '*.in' ones. > > On Tue, Oct 15, 2019 at 5:40 PM Marcin Sobczyk > <msobczyk(a)redhat.com <mailto:msobczyk@redhat.com>> wrote: > > > > On 10/15/19 1:44 PM, Kaustav Majumder wrote: >> Thanks , solved the tox issue but now pytlint is throwing >> errors. Mostly with vdsm.constants.I have lines of >> ``` >> E: 98,40: Module 'vdsm.constants' has no 'VDSM_GROUP' member >> (no-member) >> ************* Module vdsm.gluster.api >> E:232,15: Module 'vdsm.constants' has no 'EXT_MOUNT' member >> (no-member) >> ************* Module vdsm.gluster.gfapi >> E:228,35: Module 'vdsm.constants' has no 'P_VDSM' member >> (no-member) >> E:259,35: Module 'vdsm.constants' has no 'P_VDSM' member >> (no-member) >> ************* Module vdsm.supervdsm_api.udev >> ``` >> for all places wherever vdsm.constants is required. Any >> change I am unaware of. > Can you please pastebin the contents of your > 'lib/vdsm/common/constants.py' file? > > >> Full log here : https://pastebin.com/fb77r7Hj >> >> >> On Tue, Oct 15, 2019 at 1:17 PM Milan Zamazal >> <mzamazal(a)redhat.com <mailto:mzamazal@redhat.com>> wrote: >> >> Marcin Sobczyk <msobczyk(a)redhat.com >> <mailto:msobczyk@redhat.com>> writes: >> >> > Hi, >> > >> > On 10/14/19 3:06 PM, Kaustav Majumder wrote: >> >> >> >> Hi, >> >> I am having an issue running make check on vdsm master. >> >> >> >> ` >> >> if [ -n "$NOSE_WITH_COVERAGE" ]; then \ >> >>         mv .coverage .coverage-nose-py27; \ >> >> fi >> >> Traceback (most recent call last): >> >>   File "../tests/testrunner.py", line 70, in <module> >> >>     from vdsm import constants >> >>   File >> "/home/kmajumde/work/git/vdsm/lib/vdsm/constants.py", line >> >> 29, in <module> >> >>     from vdsm.common.constants import *  # NOQA: >> F401, F403 >> >> ` >> >> Am I missing something? Do I need to run tests >> differently? >> > did you run plane 'make' before 'make check'? >> >> Wouldn't it be worth to fix the missing dependency?  We >> hit this issue >> often. >> >> Even if we made `check' simply depend on `all', it would >> be fine IMO, >> since the running time of `all' is negligible to the >> running time of >> `check'. >> >> >> Thanks, >> >> >> >> Kaustav Majumder >> >> >> >> >> >> _______________________________________________ >> >> Devel mailing list -- devel(a)ovirt.org >> <mailto:devel@ovirt.org> >> >> To unsubscribe send an email to devel-leave(a)ovirt.org >> <mailto:devel-leave@ovirt.org> >> >> Privacy Statement: >> https://www.ovirt.org/site/privacy-policy/ >> >> oVirt Code of Conduct: >> https://www.ovirt.org/community/about/community-guidelines/ >> >> List Archives: >> >> >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/MTWRVTRJ5DL... >> > >> > _______________________________________________ >> > Devel mailing list -- devel(a)ovirt.org >> <mailto:devel@ovirt.org> >> > To unsubscribe send an email to devel-leave(a)ovirt.org >> <mailto:devel-leave@ovirt.org> >> > Privacy Statement: >> https://www.ovirt.org/site/privacy-policy/ >> > oVirt Code of Conduct: >> https://www.ovirt.org/community/about/community-guidelines/ >> > List Archives: >> > >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/BHZSO3MJH6K... >> _______________________________________________ >> Devel mailing list -- devel(a)ovirt.org >> <mailto:devel@ovirt.org> >> To unsubscribe send an email to devel-leave(a)ovirt.org >> <mailto:devel-leave@ovirt.org> >> Privacy Statement: >> https://www.ovirt.org/site/privacy-policy/ >> oVirt Code of Conduct: >> https://www.ovirt.org/community/about/community-guidelines/ >> List Archives: >> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7BJS3M6EVE7... >> >> >> >> -- >> >> Thanks, >> >> Kaustav Majumder >> > > > > -- > > Thanks, > > Kaustav Majumder > -- Thanks, Kaustav Majumder